blimp/client/public/session/assignment.cc - Issue 2462183002: GRPC Stream implementation of HeliumStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/session/assignment.cc

Issue 2462183002: GRPC Stream implementation of HeliumStream

Patch Set: Fixed a few minor comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/public/session/assignment.cc

diff --git a/blimp/client/public/session/assignment.cc b/blimp/client/public/session/assignment.cc

index 333875fb2e07f0f8259853e2508ba73c84472225..ac938613ab08863d089c52a08022fd526a0f4067 100644

--- a/blimp/client/public/session/assignment.cc

+++ b/blimp/client/public/session/assignment.cc

@@ -16,7 +16,8 @@ Assignment::Assignment(const Assignment& other) = default;

Assignment::~Assignment() {}

bool Assignment::IsValid() const {

- if (engine_endpoint.address().empty() || engine_endpoint.port() == 0 ||

+ if (assignment_options.engine_endpoint.address().empty() ||

+ assignment_options.engine_endpoint.port() == 0 ||

transport_protocol == TransportProtocol::UNKNOWN) {

return false;

}