Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: blimp/client/core/session/connection_status.cc

Issue 2462183002: GRPC Stream implementation of HeliumStream
Patch Set: Fixed a few minor comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/session/connection_status.cc
diff --git a/blimp/client/core/session/connection_status.cc b/blimp/client/core/session/connection_status.cc
index 069dcbb684a10e622d5b755aed10fcb851225147..38663fbe0c9d63f4531647a197b4761763d8e6cc 100644
--- a/blimp/client/core/session/connection_status.cc
+++ b/blimp/client/core/session/connection_status.cc
@@ -25,7 +25,7 @@ void ConnectionStatus::RemoveObserver(NetworkEventObserver* observer) {
void ConnectionStatus::OnAssignmentResult(int result,
const Assignment& assignment) {
if (result == AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_OK) {
- engine_endpoint_ = assignment.engine_endpoint;
+ assignment_options_ = assignment.assignment_options;
}
}
@@ -43,8 +43,9 @@ void ConnectionStatus::OnConnected() {
void ConnectionStatus::OnDisconnected(int result) {
is_connected_ = false;
UMA_HISTOGRAM_BOOLEAN("Blimp.Connected", false);
- for (auto& observer : connection_observers_)
+ for (auto& observer : connection_observers_) {
observer.OnDisconnected(result);
+ }
}
} // namespace client

Powered by Google App Engine
This is Rietveld 408576698