Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: blimp/engine/session/blimp_engine_session.h

Issue 2462183002: GRPC Stream implementation of HeliumStream
Patch Set: Address gcasto comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/browser_tests/tcp_assignment.cc ('k') | blimp/engine/session/blimp_engine_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/session/blimp_engine_session.h
diff --git a/blimp/engine/session/blimp_engine_session.h b/blimp/engine/session/blimp_engine_session.h
index f815a5a4102bbea8adf17761084503447995292e..f2f76d5b46918be5dc558b119fa3b409856d28c7 100644
--- a/blimp/engine/session/blimp_engine_session.h
+++ b/blimp/engine/session/blimp_engine_session.h
@@ -12,6 +12,7 @@
#include "base/macros.h"
#include "blimp/common/proto/blimp_message.pb.h"
+#include "blimp/common/public/session/assignment_options.h"
#include "blimp/engine/feature/engine_render_widget_feature.h"
#include "blimp/engine/feature/engine_settings_feature.h"
#include "blimp/engine/feature/geolocation/engine_geolocation_feature.h"
@@ -75,7 +76,7 @@ class BlimpEngineSession : public BlimpMessageProcessor,
public content::WebContentsDelegate,
public ui::InputMethodObserver {
public:
- using GetPortCallback = base::Callback<void(uint16_t)>;
+ using GetAssignmentOptionsCallback = base::Callback<void(AssignmentOptions)>;
BlimpEngineSession(std::unique_ptr<BlimpBrowserContext> browser_context,
net::NetLog* net_log,
@@ -97,7 +98,7 @@ class BlimpEngineSession : public BlimpMessageProcessor,
BlobChannelService* GetBlobChannelService();
// Gets Engine's listening port. Invokes callback with the allocated port.
- void GetEnginePortForTesting(const GetPortCallback& callback);
+ void GetAssignmentOptions(const GetAssignmentOptionsCallback& callback);
// BlimpMessageProcessor implementation.
// This object handles incoming TAB_CONTROL and NAVIGATION messages directly.
« no previous file with comments | « blimp/engine/browser_tests/tcp_assignment.cc ('k') | blimp/engine/session/blimp_engine_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698