Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: blimp/net/engine_connection_manager.cc

Issue 2462183002: GRPC Stream implementation of HeliumStream
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/engine_connection_manager.cc
diff --git a/blimp/net/engine_connection_manager.cc b/blimp/net/engine_connection_manager.cc
index 88d8234ccbcc0f5ae0fb34bd731d6babab9771d1..06388d0b5cd6efda34eac6c8b4714a70fa0a37a3 100644
--- a/blimp/net/engine_connection_manager.cc
+++ b/blimp/net/engine_connection_manager.cc
@@ -11,6 +11,7 @@
#include "blimp/net/blimp_connection.h"
#include "blimp/net/blimp_transport.h"
#include "blimp/net/message_port.h"
+#include "blimp/net/grpc_engine_transport.h"
#include "blimp/net/tcp_engine_transport.h"
#include "net/base/ip_address.h"
#include "net/base/net_errors.h"
@@ -36,10 +37,8 @@ void EngineConnectionManager::ConnectTransport(
}
case EngineTransportType::GRPC: {
- NOTIMPLEMENTED();
- // TODO(perumaal): Unimplemented as yet.
- // transport_ =
- // base::MakeUnique<GrpcEngineTransport>(ip_endpoint.ToString());
+ transport_ =
+ base::MakeUnique<GrpcEngineTransport>(ip_endpoint->ToString());
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698