Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: blimp/client/core/session/client_network_components.cc

Issue 2462183002: GRPC Stream implementation of HeliumStream
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/common/proto/BUILD.gn » ('j') | blimp/common/proto/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/session/client_network_components.cc
diff --git a/blimp/client/core/session/client_network_components.cc b/blimp/client/core/session/client_network_components.cc
index 45f722aeae43b3a0250b515210ae128f649633e6..f19ebfb9cc9d83055a8c724be87499530f1e4785 100644
--- a/blimp/client/core/session/client_network_components.cc
+++ b/blimp/client/core/session/client_network_components.cc
@@ -8,6 +8,7 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
+#include "blimp/net/grpc_client_transport.h"
#include "blimp/net/ssl_client_transport.h"
#include "net/base/net_errors.h"
@@ -48,11 +49,9 @@ void ClientNetworkComponents::ConnectWithAssignment(
transport_type = "TCP";
break;
case Assignment::GRPC:
- // TODO(perumaal): Unimplemented as yet.
- // connection_manager_->AddTransport(
- // base::MakeUnique<GrpcClientTransport>(endpoint));
+ connection_manager_->AddTransport(base::MakeUnique<GrpcClientTransport>(
+ assignment.engine_endpoint.ToString()));
transport_type = "GRPC";
- NOTIMPLEMENTED();
break;
case Assignment::UNKNOWN:
LOG(FATAL) << "Unknown transport type.";
« no previous file with comments | « no previous file | blimp/common/proto/BUILD.gn » ('j') | blimp/common/proto/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698