Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: blimp/client/public/session/assignment.cc

Issue 2462183002: GRPC Stream implementation of HeliumStream
Patch Set: Fixed a few minor comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/public/session/assignment.h" 5 #include "blimp/client/public/session/assignment.h"
6 6
7 #include "net/cert/x509_certificate.h" 7 #include "net/cert/x509_certificate.h"
8 8
9 namespace blimp { 9 namespace blimp {
10 namespace client { 10 namespace client {
11 11
12 Assignment::Assignment() : transport_protocol(TransportProtocol::UNKNOWN) {} 12 Assignment::Assignment() : transport_protocol(TransportProtocol::UNKNOWN) {}
13 13
14 Assignment::Assignment(const Assignment& other) = default; 14 Assignment::Assignment(const Assignment& other) = default;
15 15
16 Assignment::~Assignment() {} 16 Assignment::~Assignment() {}
17 17
18 bool Assignment::IsValid() const { 18 bool Assignment::IsValid() const {
19 if (engine_endpoint.address().empty() || engine_endpoint.port() == 0 || 19 if (assignment_options.engine_endpoint.address().empty() ||
20 assignment_options.engine_endpoint.port() == 0 ||
20 transport_protocol == TransportProtocol::UNKNOWN) { 21 transport_protocol == TransportProtocol::UNKNOWN) {
21 return false; 22 return false;
22 } 23 }
23 if (transport_protocol == TransportProtocol::SSL && !cert) { 24 if (transport_protocol == TransportProtocol::SSL && !cert) {
24 return false; 25 return false;
25 } 26 }
26 return true; 27 return true;
27 } 28 }
28 29
29 } // namespace client 30 } // namespace client
30 } // namespace blimp 31 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698