blimp/common/proto/helium_service.proto - Issue 2462183002: GRPC Stream implementation of HeliumStream

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/helium_service.proto

Issue 2462183002: GRPC Stream implementation of HeliumStream

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //

5 // Message definitions shared across proto files.

6	4

7 syntax = "proto2";	5 syntax = "proto3";

8	6

9 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

10	8

11 package blimp;	9 package blimp;

12	10

13 message EmptyMessage {}	11 message HeliumWrapper {

	12 bytes serialized_helium_message = 1;
	Kevin M 2016/10/31 21:33:25 Since we'll be sending BlimpMessages and HeliumMes Since we'll be sending BlimpMessages and HeliumMessages over here, how about just "serialized_message" ?
	13 }

	14

	15 service HeliumService {

	16 rpc Stream(stream HeliumWrapper) returns (stream HeliumWrapper) {}

	17 }

OLD	NEW