Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2462153003: DevTools: Automagically detect user compiled content shell in npm test (Closed)

Created:
4 years, 1 month ago by chenwilliam
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Automagically detect user compiled content shell in npm test This should provide a seamless workflow if you're using: * full chromium checkout - uses your compiled content shell (from out/Release) if possible, otherwise it falls back to fetching a content shell from the cloud. It will also compile devtools front-end so it can run tests in release mode. * front-end github checkout - always uses a pre-compiled content shell fetched from the cloud This deprecates the run_inspector_tests.sh which will be replaced by "npm test". I've also added documentation on `npm test` in the README. BUG=654486 Committed: https://crrev.com/b57bb537043ed5d20edcc5f58c9a21575c03076b Cr-Commit-Position: refs/heads/master@{#429076}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Feature parity with run_inspector_tests.sh #

Patch Set 4 : minor addition to readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/readme.md View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/npm_test.js View 1 2 3 chunks +26 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/run_inspector_tests.sh View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
chenwilliam
PTAL.
4 years, 1 month ago (2016-11-01 18:00:57 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-11-01 18:46:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462153003/60001
4 years, 1 month ago (2016-11-01 18:48:13 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-01 19:47:21 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 19:57:39 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b57bb537043ed5d20edcc5f58c9a21575c03076b
Cr-Commit-Position: refs/heads/master@{#429076}

Powered by Google App Engine
This is Rietveld 408576698