Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/d8.cc

Issue 2462143002: [Tracing] Remove unused excluded categories list. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/libplatform/v8-tracing.h ('k') | src/libplatform/tracing/trace-config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index f55e17cda9295f7178eae29e8b68d2abb8b3f356..3c6bda09d71252b499ab976abe4efc45893f0f22 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -204,7 +204,6 @@ const char kRecordModeParam[] = "record_mode";
const char kEnableSystraceParam[] = "enable_systrace";
const char kEnableArgumentFilterParam[] = "enable_argument_filter";
const char kIncludedCategoriesParam[] = "included_categories";
-const char kExcludedCategoriesParam[] = "excluded_categories";
class TraceConfigParser {
public:
@@ -232,10 +231,8 @@ class TraceConfigParser {
kEnableArgumentFilterParam)) {
trace_config->EnableArgumentFilter();
}
- UpdateCategoriesList(isolate, context, trace_config_object,
- kIncludedCategoriesParam, trace_config);
- UpdateCategoriesList(isolate, context, trace_config_object,
- kExcludedCategoriesParam, trace_config);
+ UpdateIncludedCategoriesList(isolate, context, trace_config_object,
+ trace_config);
}
private:
@@ -249,10 +246,11 @@ class TraceConfigParser {
return false;
}
- static int UpdateCategoriesList(
+ static int UpdateIncludedCategoriesList(
v8::Isolate* isolate, Local<Context> context, Local<v8::Object> object,
- const char* property, platform::tracing::TraceConfig* trace_config) {
- Local<Value> value = GetValue(isolate, context, object, property);
+ platform::tracing::TraceConfig* trace_config) {
+ Local<Value> value =
+ GetValue(isolate, context, object, kIncludedCategoriesParam);
if (value->IsArray()) {
Local<Array> v8_array = Local<Array>::Cast(value);
for (int i = 0, length = v8_array->Length(); i < length; ++i) {
@@ -261,11 +259,7 @@ class TraceConfigParser {
->ToString(context)
.ToLocalChecked();
String::Utf8Value str(v->ToString(context).ToLocalChecked());
- if (kIncludedCategoriesParam == property) {
- trace_config->AddIncludedCategory(*str);
- } else {
- trace_config->AddExcludedCategory(*str);
- }
+ trace_config->AddIncludedCategory(*str);
}
return v8_array->Length();
}
« no previous file with comments | « include/libplatform/v8-tracing.h ('k') | src/libplatform/tracing/trace-config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698