Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2462143002: [Tracing] Remove unused excluded categories list. (Closed)

Created:
4 years, 1 month ago by lpy
Modified:
4 years, 1 month ago
Reviewers:
fmeawad
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Remove unused excluded categories list. We only need included categories list, excluded categories list will only work if we use regular expression in categories list, which is not supported in V8. TBR=jochen@chromium.org Committed: https://crrev.com/9c7819434365bad8de953cee6b2af115fc710aec Cr-Commit-Position: refs/heads/master@{#40681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M include/libplatform/v8-tracing.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/d8.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M src/libplatform/tracing/trace-config.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/libplatform/test-tracing.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
lpy
ptal
4 years, 1 month ago (2016-10-31 18:40:43 UTC) #4
fmeawad
lgtm
4 years, 1 month ago (2016-10-31 19:32:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462143002/1
4 years, 1 month ago (2016-10-31 19:41:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 19:44:57 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c7819434365bad8de953cee6b2af115fc710aec
Cr-Commit-Position: refs/heads/master@{#40681}

Powered by Google App Engine
This is Rietveld 408576698