Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2462083002: Add ParseStartToFirstContentfulPaint metric to @import css scanner (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ParseStartToFirstContentfulPaint metric to @import css scanner We currently only have parse start to first meaningful paint. Since the metric is still experimental let's make sure the experiment has at least one stable metric. BUG=596676 Committed: https://crrev.com/9ca202f973a177b0a02343cfbab213b85a67728b Cr-Commit-Position: refs/heads/master@{#428784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Charlie Harrison
bmcquade, ptal?
4 years, 1 month ago (2016-10-31 17:54:26 UTC) #6
Bryan McQuade
lgtm
4 years, 1 month ago (2016-10-31 17:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462083002/1
4 years, 1 month ago (2016-10-31 18:04:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293276)
4 years, 1 month ago (2016-10-31 18:14:17 UTC) #11
Charlie Harrison
oops, +isherman for histograms.xml
4 years, 1 month ago (2016-10-31 18:25:46 UTC) #13
Ilya Sherman
lgtm
4 years, 1 month ago (2016-10-31 19:54:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462083002/1
4 years, 1 month ago (2016-10-31 19:56:03 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 20:24:00 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:27:03 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ca202f973a177b0a02343cfbab213b85a67728b
Cr-Commit-Position: refs/heads/master@{#428784}

Powered by Google App Engine
This is Rietveld 408576698