Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 246203004: Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated code based on review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/HitTestResult.cpp
diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp
index 63f71c09e4fceeb2b6fd70a57a1efe9393783ba1..6bc60977c4dda8b17e1ed51068f5d9fd0a79c342 100644
--- a/Source/core/rendering/HitTestResult.cpp
+++ b/Source/core/rendering/HitTestResult.cpp
@@ -378,10 +378,10 @@ bool HitTestResult::isContentEditable() const
if (!m_innerNonSharedNode)
return false;
- if (isHTMLTextAreaElement(*m_innerNonSharedNode))
+ if (isHTMLTextAreaElement(*m_innerNonSharedNode) && !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly())
yosin_UTC9 2014/05/07 01:12:03 nit: Can we move |isDisabledOrReadOnly()| call to
return true;
- if (isHTMLInputElement(*m_innerNonSharedNode))
+ if (isHTMLInputElement(*m_innerNonSharedNode) && !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly())
yosin_UTC9 2014/05/07 01:12:03 nit: Can we move |isDisabledOrReadOnly()| call to
return toHTMLInputElement(*m_innerNonSharedNode).isTextField();
return m_innerNonSharedNode->rendererIsEditable();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698