Source/core/rendering/HitTestResult.cpp - Issue 246203004: Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 246203004: Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated Layout Test case HTML based on review comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/readonly-disabled-hittest.html ('K') | « LayoutTests/editing/selection/readonly-disabled-hittest-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/HitTestResult.cpp

diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp

index 1705f81fcd2758899f4607c446fb69327d64e867..f4b92e41a8fd28d50f2fb961f40d99828c6ffba0 100644

--- a/Source/core/rendering/HitTestResult.cpp

+++ b/Source/core/rendering/HitTestResult.cpp

@@ -381,10 +381,10 @@ bool HitTestResult::isContentEditable() const

return false;

if (isHTMLTextAreaElement(*m_innerNonSharedNode))

- return true;

+ return !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly();

if (isHTMLInputElement(*m_innerNonSharedNode))

- return toHTMLInputElement(*m_innerNonSharedNode).isTextField();

+ return (!toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly() && toHTMLInputElement(*m_innerNonSharedNode).isTextField());

Yuta Kitamura 2014/06/03 07:01:27 nit: Outermost parentheses are not necessary

return m_innerNonSharedNode->rendererIsEditable();

}

« LayoutTests/editing/selection/readonly-disabled-hittest.html ('K') | « LayoutTests/editing/selection/readonly-disabled-hittest-expected.txt ('k') | no next file » | no next file with comments »