Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 246203004: Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/HitTestResult.cpp
diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp
index 63f71c09e4fceeb2b6fd70a57a1efe9393783ba1..12e88f1a7df8bc9cdeef01ae480594383599a267 100644
--- a/Source/core/rendering/HitTestResult.cpp
+++ b/Source/core/rendering/HitTestResult.cpp
@@ -378,6 +378,15 @@ bool HitTestResult::isContentEditable() const
if (!m_innerNonSharedNode)
return false;
+ if (m_innerNonSharedNode->isElementNode()) {
+ Element* innerElement = toElement(m_innerNonSharedNode);
+ if (innerElement->isFormControlElement()) {
yosin_UTC9 2014/04/25 01:07:20 It seems description and this change aren't matche
+ HTMLFormControlElement* formControlElement = toHTMLFormControlElement(m_innerNonSharedNode);
+ if (formControlElement->isDisabledOrReadOnly())
+ return false;
+ }
+ }
+
if (isHTMLTextAreaElement(*m_innerNonSharedNode))
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698