Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/editing/selection/readonly-disabled-hittest.html

Issue 246203004: Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added Layout Test cases for this change Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/editing/selection/readonly-disabled-hittest-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <!DOCTYPE html>
2 <html>
Yuta Kitamura 2014/05/29 06:12:30 Indentation and formatting are horribly broken in
3 <body onload="test();">
yosin_UTC9 2014/05/29 03:34:11 nit: Please decrease indentation.
AKVT 2014/05/29 07:29:29 Done.
4 <input id="normalText" type="text" value="Normal input" />
Yuta Kitamura 2014/05/29 06:12:30 "/>" notation is for XML. As long as you use HTML5
AKVT 2014/05/29 07:29:29 Done.
5 <br/>
6 <input id="readOnlyText" type="text" value="Readonly input" readonly />
7 <br/>
8 <input id="disabledText" type="text" value="Disabled input" disabled />
9 <br/>
10 <input id="readOnlyDisabledText" size="26" type="text" value="Readonly a nd Disabled input" readonly disabled />
11 <br/>
12 <textarea id="normalTextArea" value="true" >Normal textarea</textarea>
13 <br/>
14 <textarea id="readOnlyTextArea" value="true" readonly>Readonly textarea< /textarea>
15 <br/>
16 <textarea id="disabledTextArea" value="true" disabled>Disabled textarea< /textarea>
17 <br/>
18 <div id="contentEditableDiv" contenteditable="true">Content Editable DIV </div>
19 <br/>
20 <div id="result"></div>
21 <br/>
22 <script>
23 function test() {
24 if (window.testRunner)
25 testRunner.dumpAsText();
26
27 // Normal Text
28 var normalText = document.getElementById("normal Text");
29 var x = normalText.offsetParent.offsetLeft + nor malText.offsetLeft + 4;
30 var y = normalText.offsetParent.offsetTop + norm alText.offsetTop + normalText.offsetHeight / 2;
31
32 if (!window.eventSender)
33 return;
34
35 eventSender.mouseMoveTo(x, y);
36 var items = eventSender.contextClick();
37 if (items.length > 0) {
38 child = document.createTextNode("Normal input SUCCESS");
39 document.getElementById('result').appendChild(child);
40 }
41 else {
42 child = document.createTextNode("Normal input FAILURE");
43 document.getElementById('result').appendChild(child);
44 }
45 //child = document.createTextNode("<br/>");
46 child = document.createElement("br");
47 document.getElementById('result').appendChild(child);
48
49 // ReadOnly Text
50 var readOnlyText = document.getElementById("read OnlyText");
yosin_UTC9 2014/05/29 03:34:11 nit: Please fix indentation.
AKVT 2014/05/29 07:29:29 Done.
51 var x = readOnlyText.offsetParent.offsetLeft + r eadOnlyText.offsetLeft + 4;
52 var y = readOnlyText.offsetParent.offsetTop + re adOnlyText.offsetTop + readOnlyText.offsetHeight / 2;
53 if (!window.eventSender)
54 return;
55
56 eventSender.mouseMoveTo(x, y);
57 var items = eventSender.contextClick();
58 if (items.length > 0) {
59 child = document.createTextNode("Readonly input FAILURE");
60 document.getElementById('result').appendChild(child);
61 }
62 else {
63 child = document.createTextNode("Readonly input SUCCESS");
64 document.getElementById('result').appendChild(child);
65 }
66 //child = document.createTextNode("<br/>");
yosin_UTC9 2014/05/29 03:34:11 nit: Please remove commented unused statement.
AKVT 2014/05/29 07:29:29 Done.
67 child = document.createElement("br");
68 document.getElementById('result').appendChild(child);
69
70 //Disabled Text
yosin_UTC9 2014/05/29 03:34:11 nit: Please insert a space after "//".
AKVT 2014/05/29 07:29:29 Done.
71 var disabledText = document.getElementById("disa bledText");
yosin_UTC9 2014/05/29 03:34:11 nit: Please fix indentation.
AKVT 2014/05/29 07:29:29 Done.
72 var x = disabledText.offsetParent.offsetLeft + d isabledText.offsetLeft + 4;
73 var y = disabledText.offsetParent.offsetTop + di sabledText.offsetTop + disabledText.offsetHeight / 2;
74 eventSender.mouseMoveTo(x, y);
75 var items = eventSender.contextClick();
76 if (items.length > 0) {
77 child = document.createTextNode("Disabled input FAILURE");
78 document.getElementById('result').appendChild(child);
79 }
80 else {
81 child = document.createTextNode("Disabled input SUCCESS");
82 document.getElementById('result').appendChild(child);
83 }
84 //child = document.createTextNode("<br/>");
85 child = document.createElement("br");
86 document.getElementById('result').appendChild(child);
87
88
89 // ReadOnly and Disabled Text
90 var readOnlyDisabledText = document.getElementBy Id("readOnlyDisabledText");
yosin_UTC9 2014/05/29 03:34:11 nit: Could you fix indentation?
AKVT 2014/05/29 07:29:29 Done.
91 var x = readOnlyDisabledText.offsetParent.offset Left + readOnlyDisabledText.offsetLeft + 4;
92 var y = readOnlyDisabledText.offsetParent.offset Top + readOnlyDisabledText.offsetTop + readOnlyDisabledText.offsetHeight / 2;
93 if (!window.eventSender)
94 return;
95
96 eventSender.mouseMoveTo(x, y);
97 var items = eventSender.contextClick();
98 if (items.length > 0) {
99 child = document.createTextNode("Readonly an d Disabled input FAILURE");
100 document.getElementById('result').appendChild(child);
101 }
102 else {
103 child = document.createTextNode("Readonly and Disabled input SUCCESS");
104 document.getElementById('result').appendChild(child);
105 }
106 //child = document.createTextNode("<br/>");
yosin_UTC9 2014/05/29 03:34:11 nit: Could you remove comment out statement?
AKVT 2014/05/29 07:29:29 Done.
107 child = document.createElement("br");
108 document.getElementById('result').appendChild(child);
yosin_UTC9 2014/05/29 03:34:11 nit: Please use one kind of quotation mark. I reco
AKVT 2014/05/29 07:29:29 Done.
109
110 // Normal TextArea
111 var normalTextArea = document.getElementById("no rmalTextArea");
112 var x = normalTextArea.offsetParent.offsetLeft + normalTextArea.offsetLeft + 4;
113 var y = normalTextArea.offsetParent.offsetTop + normalTextArea.offsetTop + normalTextArea.offsetHeight / 2;
114 if (!window.eventSender)
115 return;
116
117 eventSender.mouseMoveTo(x, y);
118 var items = eventSender.contextClick();
119 if (items.length > 0) {
120 child = document.createTextNode("Normal text area SUCCESS");
121 document.getElementById('result').append Child(child);
122 }
123 else {
124 child = document.createTextNode("Normal textarea FAILURE");
125 document.getElementById('result').append Child(child);
126 }
127 //child = document.createTextNode("<br/>");
128 child = document.createElement("br");
129 document.getElementById('result').appendChild(child);
130
131 // ReadOnly TextArea
132 var readOnlyTextArea = document.getElementById("readOnlyTextArea ");
133 var x = readOnlyTextArea.offsetParent.offsetLeft + readOnlyTextArea.offsetLeft + 4;
134 var y = readOnlyTextArea.offsetParent.offsetTop + readOnlyTextArea.offsetTop + readOnlyTextArea.offsetHeight / 2;
135 if (!window.eventSender)
136 return;
137
138 eventSender.mouseMoveTo(x, y);
139 var items = eventSender.contextClick();
140 if (items.length > 0) {
141 child = document.createTextNode("Readonly te xtarea FAILURE");
142 document.getElementById('result').append Child(child);
143 }
144 else {
145 child = document.createTextNode("Readonl y textarea SUCCESS");
146 document.getElementById('result').append Child(child);
147 }
148 //child = document.createTextNode("<br/>");
149 child = document.createElement("br");
150 document.getElementById('result').appendChild(child);
151
152 // Disabled TextArea
153 var disabledTextArea = document.getElementById("disabledTextArea ");
154 var x = disabledTextArea.offsetParent.offsetLeft + disabledTextArea.offsetLeft + 4;
155 var y = disabledTextArea.offsetParent.offsetTop + disabledTextArea.offsetTop + disabledTextArea.offsetHeight / 2;
156 if (!window.eventSender)
157 return;
158
159 eventSender.mouseMoveTo(x, y);
160 var items = eventSender.contextClick();
161 if (items.length > 0) {
162 child = document.createTextNode("Disabled te xtarea FAILURE");
163 document.getElementById('result').append Child(child);
164 }
165 else {
166 child = document.createTextNode("Disable d textarea SUCCESS");
167 document.getElementById('result').append Child(child);
168 }
169 //child = document.createTextNode("<br/>");
170 child = document.createElement("br");
171 document.getElementById('result').appendChild(child);
172
173 // ContentEditable Div
174 var contentEditableDiv = document.getElementById("contentEditabl eDiv");
175 var x = contentEditableDiv.offsetParent.offsetLe ft + contentEditableDiv.offsetLeft + 4;
176 var y = contentEditableDiv.offsetParent.offsetTo p + contentEditableDiv.offsetTop + contentEditableDiv.offsetHeight / 2;
177 if (!window.eventSender)
178 return;
179
180 eventSender.mouseMoveTo(x, y);
181 var items = eventSender.contextClick();
182 if (items.length > 0) {
183 child = document.createTextNode("Content Edi table DIV SUCCESS");
184 document.getElementById('result').append Child(child);
185 }
186 else {
187 child = document.createTextNode("Content Editable DIV FAILURE");
188 document.getElementById('result').append Child(child);
189 }
190 //child = document.createTextNode("<br/>");
191 child = document.createElement("br");
192 document.getElementById('result').appendChild(child);
193 }
194
195 </script>
196 </body>
197 </html>
198
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/editing/selection/readonly-disabled-hittest-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698