Deferred image generator subsetting

Deferred image generator subsetting

Instead of invoking the generator at subset time, instantiate a new
SkImage_Generator with its own cacherator but shared generator.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2462013003

Committed: https://skia.googlesource.com/skia/+/8bd45cd98eb0eff1fb074fac9f469fdad5ca51f9

[f(malita), 2016-10-31 16:36:40]

Description was changed from

==========
Deferred image generator subsetting

Instead of invoking the generator at subset time, instantiate a new
SkImage_Generator with its own cacherator but shared generator.

R=reed@google.com
==========

to

==========
Deferred image generator subsetting

Instead of invoking the generator at subset time, instantiate a new
SkImage_Generator with its own cacherator but shared generator.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2462013003
==========

[f(malita), 2016-10-31 17:21:51]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 17:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 17:44:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:44:29]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-11-04 17:50:29]

Updated per conversation, to fold the origin into the subset arg and unify the
ctor around SharedGenerator.

[f(malita), 2016-11-04 17:50:34]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:50:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-11-04 17:51:01]

The CQ bit was unchecked by fmalita@chromium.org

[reed1, 2016-11-04 17:55:29]

lgtm

https://codereview.chromium.org/2462013003/diff/40001/src/core/SkImageCachera...
File src/core/SkImageCacherator.cpp (right):

https://codereview.chromium.org/2462013003/diff/40001/src/core/SkImageCachera...
src/core/SkImageCacherator.cpp:64: const SkImageInfo& info =
fSharedGenerator->fGenerator->getInfo();
I presume its "safe" to access the generator w/o grabbing the shared mutex?

[f(malita), 2016-11-04 18:10:16]

https://codereview.chromium.org/2462013003/diff/40001/src/core/SkImageCachera...
File src/core/SkImageCacherator.cpp (right):

https://codereview.chromium.org/2462013003/diff/40001/src/core/SkImageCachera...
src/core/SkImageCacherator.cpp:64: const SkImageInfo& info =
fSharedGenerator->fGenerator->getInfo();
On 2016/11/04 17:55:29, reed1 wrote:
> I presume its "safe" to access the generator w/o grabbing the shared mutex?

Added comment, will follow up with cleanup CL.

[f(malita), 2016-11-04 18:10:20]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-11-04 18:10:20]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2462013003/#ps60001
(title: "unlocked generator access comments")

[commit-bot: I haz the power, 2016-11-04 18:10:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 18:36:33]

Description was changed from

==========
Deferred image generator subsetting

Instead of invoking the generator at subset time, instantiate a new
SkImage_Generator with its own cacherator but shared generator.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2462013003
==========

to

==========
Deferred image generator subsetting

Instead of invoking the generator at subset time, instantiate a new
SkImage_Generator with its own cacherator but shared generator.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2462013003

Committed:
https://skia.googlesource.com/skia/+/8bd45cd98eb0eff1fb074fac9f469fdad5ca51f9
==========

[commit-bot: I haz the power, 2016-11-04 18:36:34]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8bd45cd98eb0eff1fb074fac9f469fdad5ca51f9