Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2461893002: Revert of Change FX_BOOL definition from int to bool. (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Change FX_BOOL definition from int to bool. (patchset #15 id:250001 of https://codereview.chromium.org/2453473003/ ) Reason for revert: Potentially blocking the roll, speculative revert. See: https://codereview.chromium.org/2464643002/ Original issue's description: > Change FX_BOOL definition from int to bool. > > If this CL sticks, we can then remove it entirely. > > Committed: https://pdfium.googlesource.com/pdfium/+/dd65283408d9137e2f142e78dff2a1826baab5fd TBR=thestig@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/747dcf775c5cb661e96a639f73322cc489d8590f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M core/fxcrt/fx_system.h View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
Created Revert of Change FX_BOOL definition from int to bool.
4 years, 1 month ago (2016-10-29 18:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461893002/1
4 years, 1 month ago (2016-10-29 18:27:13 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 18:27:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/747dcf775c5cb661e96a639f73322cc489d8...

Powered by Google App Engine
This is Rietveld 408576698