Remove DEPS restriction content_public/ to content/ (Java)

Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=658678, 335690
Committed: https://crrev.com/bfe32da7ffd850ddfdd58f6c775f0dc1a92eed78
Cr-Commit-Position: refs/heads/master@{#428684}

[Zhiqiang Zhang (Slow), 2016-10-28 23:48:31]

Description was changed from

==========
Remove DEPS restriction to content/ from content_public/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=NONE
==========

to

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=NONE
==========

[Zhiqiang Zhang (Slow), 2016-10-28 23:48:44]

zqzhang@chromium.org changed reviewers:
+ boliu@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-28 23:48:45]

PTAL

[boliu, 2016-10-29 00:04:43]

boliu@chromium.org changed reviewers:
+ aelias@chromium.org, dtrainor@chromium.org, tedchoc@chromium.org,
yfriedman@chromium.org

[boliu, 2016-10-29 00:04:43]

add all the content/public/android owners. but most are not here, so I'm going
to make a decision here

this DEPS rule makes no sense, and it's exactly the opposite of this DEPS rule
for content/public/browser:
https://cs.chromium.org/chromium/src/content/public/browser/DEPS?rcl=0&l=3

while it's nice if content_public only had interfaces which shouldn't depend on
implementation, static methods is still a thing, and especially in java, can't
just be magically implemented somewhere else

specifically it's to address implement this static method:
https://codereview.chromium.org/2444833004/diff/100001/content/public/android...

[boliu, 2016-10-29 00:05:21]

lgtm

[aelias_OOO_until_Jul13, 2016-10-29 00:12:38]

Seems OK given that it's the opposite of the other restriction.  Could you link
the motivating bug number?  Is it http://crbug.com/658678 ?

[boliu, 2016-10-29 00:23:00]

also link crbug.com/335690 maybe?

[Zhiqiang Zhang (Slow), 2016-10-29 00:33:54]

Description was changed from

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=NONE
==========

to

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=658678,335690
==========

[Zhiqiang Zhang (Slow), 2016-10-29 00:34:37]

On 2016/10/29 00:23:00, boliu wrote:
> also link crbug.com/335690 maybe?

> Seems OK given that it's the opposite of the other restriction.  Could you
link
> the motivating bug number?  Is it http://crbug.com/658678 ?

Done for the links

[Zhiqiang Zhang (Slow), 2016-10-29 00:34:45]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 00:35:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 00:43:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 00:43:20]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2016-10-31 10:55:30]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-10-31 10:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 11:04:37]

Description was changed from

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=658678,335690
==========

to

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=658678,335690
==========

[commit-bot: I haz the power, 2016-10-31 11:04:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-31 11:06:16]

Description was changed from

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=658678,335690
==========

to

==========
Remove DEPS restriction content_public/ to content/ (Java)

The DEPS rules for Java content_public/ is wrong. It should be able to
import classes from content/. This CL removes the restriction.

BUG=658678,335690

Committed: https://crrev.com/bfe32da7ffd850ddfdd58f6c775f0dc1a92eed78
Cr-Commit-Position: refs/heads/master@{#428684}
==========

[commit-bot: I haz the power, 2016-10-31 11:06:17]

Patchset 1 (id:??) landed as
https://crrev.com/bfe32da7ffd850ddfdd58f6c775f0dc1a92eed78
Cr-Commit-Position: refs/heads/master@{#428684}