Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2461813002: Treat a GIF with no color table as transparent (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Treat a GIF with no color table as transparent When checking to see whether a GIF has transparency to determine its alpha type, treat an empty color table as having alpha, since we will draw it as a transparent image. (This is a separate bug from skbug.com/5883, but the image I used to verify that bug was drawn to 565 as black. The fix is to not support 565 in that case, by changing its recommended alpha type.) BUG=skia:5883 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461813002 Committed: https://skia.googlesource.com/skia/+/2f7068aec9906168b3c142b5057e098114376cc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/gif/SkGifImageReader.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
4 years, 1 month ago (2016-10-28 21:28:19 UTC) #3
msarett
lgtm
4 years, 1 month ago (2016-10-28 21:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461813002/1
4 years, 1 month ago (2016-10-31 11:25:27 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 11:45:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f7068aec9906168b3c142b5057e098114376cc9

Powered by Google App Engine
This is Rietveld 408576698