Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2461803004: Remove V8CollectableDuringMinorGC node flag (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved. 5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
7 * (http://www.torchmobile.com/) 7 * (http://www.torchmobile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 clearFlag(SVGFilterNeedsLayerUpdateFlag); 487 clearFlag(SVGFilterNeedsLayerUpdateFlag);
488 } 488 }
489 489
490 void setIsLink(bool f); 490 void setIsLink(bool f);
491 491
492 bool hasEventTargetData() const { return getFlag(HasEventTargetDataFlag); } 492 bool hasEventTargetData() const { return getFlag(HasEventTargetDataFlag); }
493 void setHasEventTargetData(bool flag) { 493 void setHasEventTargetData(bool flag) {
494 setFlag(flag, HasEventTargetDataFlag); 494 setFlag(flag, HasEventTargetDataFlag);
495 } 495 }
496 496
497 bool isV8CollectableDuringMinorGC() const {
498 return getFlag(V8CollectableDuringMinorGCFlag);
499 }
500 void markV8CollectableDuringMinorGC() {
501 setFlag(true, V8CollectableDuringMinorGCFlag);
502 }
503 void clearV8CollectableDuringMinorGC() {
504 setFlag(false, V8CollectableDuringMinorGCFlag);
505 }
506
507 virtual void setFocused(bool flag); 497 virtual void setFocused(bool flag);
508 virtual void setActive(bool flag = true); 498 virtual void setActive(bool flag = true);
509 virtual void setDragged(bool flag); 499 virtual void setDragged(bool flag);
510 virtual void setHovered(bool flag = true); 500 virtual void setHovered(bool flag = true);
511 501
512 virtual short tabIndex() const; 502 virtual short tabIndex() const;
513 503
514 virtual Node* focusDelegate(); 504 virtual Node* focusDelegate();
515 // This is called only when the node is focused. 505 // This is called only when the node is focused.
516 virtual bool shouldHaveFocusAppearance() const; 506 virtual bool shouldHaveFocusAppearance() const;
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
840 NeedsStyleInvalidationFlag = 1 << 16, 830 NeedsStyleInvalidationFlag = 1 << 16,
841 ChildNeedsDistributionRecalcFlag = 1 << 17, 831 ChildNeedsDistributionRecalcFlag = 1 << 17,
842 ChildNeedsStyleRecalcFlag = 1 << 18, 832 ChildNeedsStyleRecalcFlag = 1 << 18,
843 StyleChangeMask = 833 StyleChangeMask =
844 1 << nodeStyleChangeShift | 1 << (nodeStyleChangeShift + 1), 834 1 << nodeStyleChangeShift | 1 << (nodeStyleChangeShift + 1),
845 835
846 CustomElementStateMask = 0x3 << nodeCustomElementShift, 836 CustomElementStateMask = 0x3 << nodeCustomElementShift,
847 837
848 HasNameOrIsEditingTextFlag = 1 << 23, 838 HasNameOrIsEditingTextFlag = 1 << 23,
849 HasWeakReferencesFlag = 1 << 24, 839 HasWeakReferencesFlag = 1 << 24,
850 V8CollectableDuringMinorGCFlag = 1 << 25, 840 HasEventTargetDataFlag = 1 << 25,
851 HasEventTargetDataFlag = 1 << 26,
852 841
853 V0CustomElementFlag = 1 << 27, 842 V0CustomElementFlag = 1 << 26,
854 V0CustomElementUpgradedFlag = 1 << 28, 843 V0CustomElementUpgradedFlag = 1 << 27,
855 844
856 NeedsReattachLayoutTree = 1 << 29, 845 NeedsReattachLayoutTree = 1 << 28,
857 ChildNeedsReattachLayoutTree = 1 << 30, 846 ChildNeedsReattachLayoutTree = 1 << 29,
858 847
859 DefaultNodeFlags = IsFinishedParsingChildrenFlag | NeedsReattachStyleChange 848 DefaultNodeFlags = IsFinishedParsingChildrenFlag | NeedsReattachStyleChange
860 }; 849 };
861 850
862 // 1 bit remaining. 851 // 1 bit remaining.
863 852
864 bool getFlag(NodeFlags mask) const { return m_nodeFlags & mask; } 853 bool getFlag(NodeFlags mask) const { return m_nodeFlags & mask; }
865 void setFlag(bool f, NodeFlags mask) { 854 void setFlag(bool f, NodeFlags mask) {
866 m_nodeFlags = (m_nodeFlags & ~mask) | (-(int32_t)f & mask); 855 m_nodeFlags = (m_nodeFlags & ~mask) | (-(int32_t)f & mask);
867 } 856 }
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 } // namespace blink 1024 } // namespace blink
1036 1025
1037 #ifndef NDEBUG 1026 #ifndef NDEBUG
1038 // Outside the WebCore namespace for ease of invocation from gdb. 1027 // Outside the WebCore namespace for ease of invocation from gdb.
1039 void showNode(const blink::Node*); 1028 void showNode(const blink::Node*);
1040 void showTree(const blink::Node*); 1029 void showTree(const blink::Node*);
1041 void showNodePath(const blink::Node*); 1030 void showNodePath(const blink::Node*);
1042 #endif 1031 #endif
1043 1032
1044 #endif // Node_h 1033 #endif // Node_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698