Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2461773002:
add isAlphaOnly() query (Closed)
|
Created:
4 years, 1 month ago by reed1 Modified:
4 years, 1 month ago Reviewers:
robertphillips CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionadd isAlphaOnly() query
BUG=skia:5904
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002
TBR=
Committed: https://skia.googlesource.com/skia/+/9e2ed83f9b29d91058ba411a4137d099877a48b2
Patch Set 1 #Patch Set 2 : add test #
Total comments: 1
Messages
Total messages: 25 (15 generated)
Description was changed from ========== add isAlphaOnly() query BUG=skia: ========== to ========== add isAlphaOnly() query BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 ==========
Description was changed from ========== add isAlphaOnly() query BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 ========== to ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 ==========
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reed@google.com changed reviewers: + robertphillips@google.com
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-10-29 02:58 UTC
Description was changed from ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 ========== to ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 TBR= ==========
The CQ bit was unchecked by reed@google.com
Description was changed from ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 TBR= ========== to ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 ==========
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-10-29 03:35 UTC
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full Skia committer
Description was changed from ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 ========== to ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 TBR= ==========
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 TBR= ========== to ========== add isAlphaOnly() query BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 TBR= Committed: https://skia.googlesource.com/skia/+/9e2ed83f9b29d91058ba411a4137d099877a48b2 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9e2ed83f9b29d91058ba411a4137d099877a48b2
Message was sent while issue was closed.
lgtm https://codereview.chromium.org/2461773002/diff/20001/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/2461773002/diff/20001/include/core/SkImage.h#... include/core/SkImage.h:171: /** fi ? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
