Use CompositeMask instead of TransferBitmap when drawing type 3 text

Use CompositeMask instead of TransferBitmap when drawing type 3 text

TransferBitmap seems to work improperly when the glyph boxes overlap.
In particular, after drawing a glyph, the next glyph's blanks will
override what the previous glyph drew, and this is not the correct
behavior. While on it, use CheckedNumeric to do operations safely.
For reference of somewhere where something similar is done, see:
https://cs.chromium.org/chromium/src/third_party/pdfium/core/fxge/ge/cfx_renderdevice.cpp?sq=package:chromium&rcl=1477581616&l=988

BUG=513954
Committed: https://pdfium.googlesource.com/pdfium/+/b849e816eee20c256cf1da94f4ba9e233b13ac23

[npm, 2016-10-28 18:34:07]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:34:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-28 18:52:09]

npm@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[npm, 2016-10-28 18:52:10]

PTAL. Accidentally deleted two blank spaces, will restore.

[Tom Sepez, 2016-10-28 18:56:10]

lgtm

[Lei Zhang, 2016-10-28 18:56:31]

Is it easy to make a PDF with some type 3 fonts to exercise this code?

[Lei Zhang, 2016-10-28 18:58:20]

lgtm

https://codereview.chromium.org/2461743002/diff/1/core/fpdfapi/render/fpdf_re...
File core/fpdfapi/render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/2461743002/diff/1/core/fpdfapi/render/fpdf_re...
core/fpdfapi/render/fpdf_render_text.cpp:315: pdfium::base::CheckedNumeric<int>
left = glyph.m_OriginX;
nit: include the header for CheckedNumeric.

[commit-bot: I haz the power, 2016-10-28 18:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:58:50]

Dry run: This issue passed the CQ dry run.

[npm, 2016-10-28 19:26:25]

https://codereview.chromium.org/2461743002/diff/1/core/fpdfapi/render/fpdf_re...
File core/fpdfapi/render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/2461743002/diff/1/core/fpdfapi/render/fpdf_re...
core/fpdfapi/render/fpdf_render_text.cpp:315: pdfium::base::CheckedNumeric<int>
left = glyph.m_OriginX;
On 2016/10/28 18:58:20, Lei Zhang wrote:
> nit: include the header for CheckedNumeric.

Done.

[npm, 2016-10-28 19:26:29]

The CQ bit was checked by npm@chromium.org

[npm, 2016-10-28 19:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2461743002/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-10-28 19:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-28 19:30:14]

On 2016/10/28 18:56:31, Lei Zhang wrote:
> Is it easy to make a PDF with some type 3 fonts to exercise this code?

Hmm I'm not sure, I'll try. It would be nice to have, for testing.

[commit-bot: I haz the power, 2016-10-28 19:47:50]

Description was changed from

==========
Use CompositeMask instead of TransferBitmap when drawing type 3 text

TransferBitmap seems to work improperly when the glyph boxes overlap.
In particular, after drawing a glyph, the next glyph's blanks will
override what the previous glyph drew, and this is not the correct
behavior. While on it, use CheckedNumeric to do operations safely.
For reference of somewhere where something similar is done, see:
https://cs.chromium.org/chromium/src/third_party/pdfium/core/fxge/ge/cfx_rend...

BUG=513954
==========

to

==========
Use CompositeMask instead of TransferBitmap when drawing type 3 text

TransferBitmap seems to work improperly when the glyph boxes overlap.
In particular, after drawing a glyph, the next glyph's blanks will
override what the previous glyph drew, and this is not the correct
behavior. While on it, use CheckedNumeric to do operations safely.
For reference of somewhere where something similar is done, see:
https://cs.chromium.org/chromium/src/third_party/pdfium/core/fxge/ge/cfx_rend...

BUG=513954

Committed:
https://pdfium.googlesource.com/pdfium/+/b849e816eee20c256cf1da94f4ba9e233b13...
==========

[commit-bot: I haz the power, 2016-10-28 19:47:51]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b849e816eee20c256cf1da94f4ba9e233b13...