Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2461733002: [v8 runtime stats] Migrate the runtime stats mapper to use the runtime stats metric instead (Closed)

Created:
4 years, 1 month ago by fmeawad
Modified:
4 years, 1 month ago
Reviewers:
eakuefner, benjhayden
CC:
catapult-reviews_chromium.org, Camillo Bruni
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[v8 runtime stats] Migrate the runtime stats mapper to use the runtime stats metric instead This experimental mapper was faling due to changes in the value system. Now that we have a corresponding metric, I am migrating it to use that metric instead which will help with reducing maintainence on that mapper in the future. TBR=eakuefner@chromium.org,benjhayden@chromium.org Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dd92ff1f4d6082cef76c0ed254b2e6050ddcb0aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -57 lines) Patch
M trace_processor/experimental/mappers/v8_callstats_dump.html View 2 chunks +17 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461733002/1
4 years, 1 month ago (2016-10-28 17:52:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dd92ff1f4d6082cef76c0ed254b2e6050ddcb0aa
4 years, 1 month ago (2016-10-28 18:16:58 UTC) #5
eakuefner
Why do you need the mapper at all any more? Can it be deleted? It ...
4 years, 1 month ago (2016-10-28 18:21:20 UTC) #6
fmeawad
4 years, 1 month ago (2016-10-28 18:31:37 UTC) #7
Message was sent while issue was closed.
On 2016/10/28 18:21:20, eakuefner wrote:
> Why do you need the mapper at all any more? Can it be deleted? It seems like
> you're essentially just passing through the results of the metric. It's not
> necessary to have a mapper just to work with trace processor; metric support
is
> built-in.

I need the mapper to change the format of the result to fit the rest of the
experiment
I am running. The experiment will run for another 2 weeks, and it is easier for
me
to maintain the current pipeline as is for now. Once the experiment is over, I
will delete
the related files.

Powered by Google App Engine
This is Rietveld 408576698