Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: components/sync/device_info/device_info_service.h

Issue 2461723002: [Sync] DeviceInfoService static method and error cleanup. (Closed)
Patch Set: removing stdint.h from device_info_service.h Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/device_info/device_info_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/device_info/device_info_service.h
diff --git a/components/sync/device_info/device_info_service.h b/components/sync/device_info/device_info_service.h
index aa37d3046b3f0845d99e138d5d7c40ecbf3f0346..958f0dbcab5e91bdca8384503c0cc96637c54fb9 100644
--- a/components/sync/device_info/device_info_service.h
+++ b/components/sync/device_info/device_info_service.h
@@ -5,8 +5,6 @@
#ifndef COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SERVICE_H_
#define COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SERVICE_H_
-#include <stdint.h>
-
#include <map>
#include <memory>
#include <string>
@@ -75,16 +73,6 @@ class DeviceInfoService : public ModelTypeSyncBridge, public DeviceInfoTracker {
using ClientIdToSpecifics =
std::map<std::string, std::unique_ptr<sync_pb::DeviceInfoSpecifics>>;
- static std::unique_ptr<sync_pb::DeviceInfoSpecifics> CopyToSpecifics(
- const DeviceInfo& info);
-
- // Allocate new DeviceInfo from SyncData.
- static std::unique_ptr<DeviceInfo> CopyToModel(
- const sync_pb::DeviceInfoSpecifics& specifics);
- // Conversion as we prepare to hand data to the processor.
- static std::unique_ptr<EntityData> CopyToEntityData(
- const sync_pb::DeviceInfoSpecifics& specifics);
-
// Store SyncData in the cache and durable storage.
void StoreSpecifics(std::unique_ptr<sync_pb::DeviceInfoSpecifics> specifics,
ModelTypeStore::WriteBatch* batch);
@@ -139,10 +127,6 @@ class DeviceInfoService : public ModelTypeSyncBridge, public DeviceInfoTracker {
// datatype, since these errors prevent us from knowing if sync is enabled.
void ReportStartupErrorToSync(const std::string& msg);
- // Find the timestamp for the last time this |device_info| was edited.
- static base::Time GetLastUpdateTime(
- const sync_pb::DeviceInfoSpecifics& specifics);
-
// |local_device_info_provider_| isn't owned.
const LocalDeviceInfoProvider* const local_device_info_provider_;
« no previous file with comments | « no previous file | components/sync/device_info/device_info_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698