Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3973)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/process_manager_browsertest.cc

Issue 2461693002: Change Isolate Extensions to be off by default. (Closed)
Patch Set: Fixes based on review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/process_management_browsertest.cc ('k') | chrome/common/extensions/extension_process_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/process_manager_browsertest.cc
diff --git a/chrome/browser/extensions/process_manager_browsertest.cc b/chrome/browser/extensions/process_manager_browsertest.cc
index 97822afa7a200b2900c08a943df3c5aa60090f90..52a9a891b69fc99528165d8d88dbbefe0cda4089 100644
--- a/chrome/browser/extensions/process_manager_browsertest.cc
+++ b/chrome/browser/extensions/process_manager_browsertest.cc
@@ -734,24 +734,26 @@ IN_PROC_BROWSER_TEST_F(ProcessManagerBrowserTest,
main_frame->GetProcess()->GetID(),
GURL("chrome-extension://some-extension-id/resource.html")));
- EXPECT_TRUE(policy->CanCommitURL(
- extension_frame->GetProcess()->GetID(),
- GURL("blob:chrome-extension://some-extension-id/some-guid")));
- EXPECT_FALSE(policy->CanCommitURL(
- main_frame->GetProcess()->GetID(),
- GURL("blob:chrome-extension://some-extension-id/some-guid")));
- EXPECT_TRUE(policy->CanCommitURL(
- extension_frame->GetProcess()->GetID(),
- GURL("chrome-extension://some-extension-id/resource.html")));
- EXPECT_FALSE(policy->CanCommitURL(
- main_frame->GetProcess()->GetID(),
- GURL("chrome-extension://some-extension-id/resource.html")));
- EXPECT_TRUE(policy->CanCommitURL(
- extension_frame->GetProcess()->GetID(),
- GURL("filesystem:chrome-extension://some-extension-id/some-path")));
- EXPECT_FALSE(policy->CanCommitURL(
- main_frame->GetProcess()->GetID(),
- GURL("filesystem:chrome-extension://some-extension-id/some-path")));
+ if (extensions::IsIsolateExtensionsEnabled()) {
+ EXPECT_TRUE(policy->CanCommitURL(
+ extension_frame->GetProcess()->GetID(),
+ GURL("blob:chrome-extension://some-extension-id/some-guid")));
+ EXPECT_FALSE(policy->CanCommitURL(
+ main_frame->GetProcess()->GetID(),
+ GURL("blob:chrome-extension://some-extension-id/some-guid")));
+ EXPECT_TRUE(policy->CanCommitURL(
+ extension_frame->GetProcess()->GetID(),
+ GURL("chrome-extension://some-extension-id/resource.html")));
+ EXPECT_FALSE(policy->CanCommitURL(
+ main_frame->GetProcess()->GetID(),
+ GURL("chrome-extension://some-extension-id/resource.html")));
+ EXPECT_TRUE(policy->CanCommitURL(
+ extension_frame->GetProcess()->GetID(),
+ GURL("filesystem:chrome-extension://some-extension-id/some-path")));
+ EXPECT_FALSE(policy->CanCommitURL(
+ main_frame->GetProcess()->GetID(),
+ GURL("filesystem:chrome-extension://some-extension-id/some-path")));
+ }
// Open a new about:blank popup from main frame. This should stay in the web
// process.
« no previous file with comments | « chrome/browser/extensions/process_management_browsertest.cc ('k') | chrome/common/extensions/extension_process_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698