Slice enum HttpResponseInfo::ConnectionInfo by QUIC version.

net/spdy/spdy_http_stream.cc

Index: net/spdy/spdy_http_stream.cc
diff --git a/net/spdy/spdy_http_stream.cc b/net/spdy/spdy_http_stream.cc
index 5fcc28c280c5b5957cd876f764ec54c91ed94633..e571615cc8e0c008fd5c62bae8ebed7722e7487a 100644
--- a/net/spdy/spdy_http_stream.cc
+++ b/net/spdy/spdy_http_stream.cc
@@ -331,10 +331,10 @@ SpdyResponseHeadersStatus SpdyHttpStream::OnResponseHeadersUpdated(
   // Don't store the SSLInfo in the response here, HttpNetworkTransaction
   // will take care of that part.
   response_info_->was_alpn_negotiated = was_alpn_negotiated_;
-  response_info_->alpn_negotiated_protocol =
-      SSLClientSocket::NextProtoToString(negotiated_protocol_);
   response_info_->request_time = stream_->GetRequestTime();
   response_info_->connection_info = HttpResponseInfo::CONNECTION_INFO_HTTP2;
+  response_info_->alpn_negotiated_protocol =
+      HttpResponseInfo::ConnectionInfoToString(response_info_->connection_info);

[Ryan Hamilton, 2016/10/28 19:02:02]

Why is "alpn_negotiated_protocol" being set to a ConnectionInfo value?

[Bence, 2016/11/01 15:11:23]

This is for consistency with QuicHttpStream, where
response_info_->alpn_negotiated_protocol() is also set to a string generated
from ConnectionInfo.

The actual value of the alpn string is dropped in SSLClientSocketImpl by choice,
only a NextProto value generated from it is stored.  So at this point, it has to
be reconstructed somehow anyway.

Really this is just a symptom of how inaccurately |alpn_negotiated_protocol| is
named.

[Ryan Hamilton, 2016/11/03 14:33:05]

Should we remove |alpn_negotiated_protocol| at some point?

[Bence, 2016/11/07 20:22:18]

Yes please, I would love that!  It's just confusing to consumers of
HttpResponseInfo, and |connection_info| has more information anyway.

   response_info_->vary_data
       .Init(*request_info_, *response_info_->headers.get());