Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: net/http/http_response_info.cc

Issue 2461683002: Slice enum HttpResponseInfo::ConnectionInfo by QUIC version. (Closed)
Patch Set: Update recently introduced CONNECTION_INFO_QUIC occurrences. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_response_info.h ('k') | net/quic/chromium/bidirectional_stream_quic_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_info.cc
diff --git a/net/http/http_response_info.cc b/net/http/http_response_info.cc
index 64d565a7347d48f7802d29c3763007eba6141154..02bfefa8dfce3d61eda56fec29afba05b25f999d 100644
--- a/net/http/http_response_info.cc
+++ b/net/http/http_response_info.cc
@@ -420,6 +420,33 @@ void HttpResponseInfo::Persist(base::Pickle* pickle,
pickle->WriteInt(ssl_info.key_exchange_group);
}
+bool HttpResponseInfo::DidUseQuic() const {
+ switch (connection_info) {
+ case CONNECTION_INFO_UNKNOWN:
+ case CONNECTION_INFO_HTTP1_1:
+ case CONNECTION_INFO_DEPRECATED_SPDY2:
+ case CONNECTION_INFO_DEPRECATED_SPDY3:
+ case CONNECTION_INFO_HTTP2:
+ case CONNECTION_INFO_DEPRECATED_HTTP2_14:
+ case CONNECTION_INFO_DEPRECATED_HTTP2_15:
+ case CONNECTION_INFO_HTTP0_9:
+ case CONNECTION_INFO_HTTP1_0:
+ return false;
+ case CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ case CONNECTION_INFO_QUIC_32:
+ case CONNECTION_INFO_QUIC_33:
+ case CONNECTION_INFO_QUIC_34:
+ case CONNECTION_INFO_QUIC_35:
+ case CONNECTION_INFO_QUIC_36:
+ return true;
+ case NUM_OF_CONNECTION_INFOS:
+ NOTREACHED();
+ return false;
+ }
+ NOTREACHED();
+ return false;
+}
+
// static
std::string HttpResponseInfo::ConnectionInfoToString(
ConnectionInfo connection_info) {
@@ -441,8 +468,18 @@ std::string HttpResponseInfo::ConnectionInfoToString(
case CONNECTION_INFO_DEPRECATED_HTTP2_15:
case CONNECTION_INFO_HTTP2:
return "h2";
- case CONNECTION_INFO_QUIC:
- return "quic/1+spdy/3";
+ case CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ return "http/2+quic";
+ case CONNECTION_INFO_QUIC_32:
+ return "http/2+quic/32";
+ case CONNECTION_INFO_QUIC_33:
+ return "http/2+quic/33";
+ case CONNECTION_INFO_QUIC_34:
+ return "http/2+quic/34";
+ case CONNECTION_INFO_QUIC_35:
+ return "http/2+quic/35";
+ case CONNECTION_INFO_QUIC_36:
+ return "http/2+quic/36";
case CONNECTION_INFO_HTTP0_9:
return "http/0.9";
case CONNECTION_INFO_HTTP1_0:
« no previous file with comments | « net/http/http_response_info.h ('k') | net/quic/chromium/bidirectional_stream_quic_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698