Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2461643002: Add missing generator dependencies in content/renderer/mus (Closed)

Created:
4 years, 1 month ago by tsniatowski
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing generator dependencies in content/renderer/mus Building //content/renderer/mus could fail due to transitive dependencies on header generators pulled in via render_frame_impl.h and render_thread_impl.h (building render_widget_mus_connection.cc or compositor_mus_connection.cc could fail). Unfortunately //content/renderer deps on //content/renderer/mus, so there's no easy way to get these deps for free (cyclic dep). BUG=655123 Committed: https://crrev.com/ef21ead8498674c5e7ccaccd2f50f89ab969cccd Cr-Commit-Position: refs/heads/master@{#428428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/mus/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tsniatowski
On 2016/10/28 06:49:56, tsniatowski wrote: > mailto:tsniatowski@opera.com changed reviewers: > + mailto:ben@chromium.org PTAL
4 years, 1 month ago (2016-10-28 06:50:08 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-10-28 14:22:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461643002/1
4 years, 1 month ago (2016-10-28 17:11:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 18:13:19 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 18:22:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef21ead8498674c5e7ccaccd2f50f89ab969cccd
Cr-Commit-Position: refs/heads/master@{#428428}

Powered by Google App Engine
This is Rietveld 408576698