Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2461633002: Missing document null pointer check in Internals. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
nainar
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Missing document null pointer check in Internals. updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks did not check if the document was null before using it. R=nainar@chromium.org BUG=657443 Committed: https://crrev.com/d2c8b4221a2dfd70b8445df939697e543e98b69a Cr-Commit-Position: refs/heads/master@{#428312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/harness/internals-no-document-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/harness/internals-no-document-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-10-28 06:11:41 UTC) #2
nainar
lgtm
4 years, 1 month ago (2016-10-28 07:33:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461633002/1
4 years, 1 month ago (2016-10-28 07:42:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 07:47:30 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 07:50:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2c8b4221a2dfd70b8445df939697e543e98b69a
Cr-Commit-Position: refs/heads/master@{#428312}

Powered by Google App Engine
This is Rietveld 408576698