CSS Motion Path: Place offset-anchor on the path

CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

Spec: https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055
Committed: https://crrev.com/29e3535e5c89d73a975bcd0a97aaefe3c8653e80
Cr-Commit-Position: refs/heads/master@{#430896}

[Eric Willigers, 2016-10-31 07:54:54]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 07:55:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-10-31 09:58:55]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 09:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-10-31 10:12:18]

Description was changed from

==========
CSS Motion Path: Place offset-anchor on the path, not transform-origin

BUG=638055
==========

to

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-position, offset-path.

BUG=638055
==========

[Eric Willigers, 2016-10-31 10:12:19]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[commit-bot: I haz the power, 2016-10-31 11:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 11:04:27]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-11-01 00:16:23]

Description was changed from

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-position, offset-path.

BUG=638055
==========

to

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-position, offset-path.

"offset-anchor: auto" is not yet supported.

BUG=638055
==========

[Eric Willigers, 2016-11-01 01:36:28]

Patchset #3 (id:40001) has been deleted

[Eric Willigers, 2016-11-01 01:36:48]

Description was changed from

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-position, offset-path.

"offset-anchor: auto" is not yet supported.

BUG=638055
==========

to

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

BUG=638055
==========

[Eric Willigers, 2016-11-01 01:58:15]

Description was changed from

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

BUG=638055
==========

to

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

Spec: https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055
==========

[alancutter (OOO until 2018), 2016-11-01 05:04:39]

On 2016/10/31 at 10:12:32, ericwilligers wrote:
> 

This patch seems to be in flux, ping me when it becomes ready.

[Eric Willigers, 2016-11-01 05:23:30]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 05:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-11-01 05:23:55]

On 2016/11/01 05:04:39, alancutter wrote:
> On 2016/10/31 at 10:12:32, ericwilligers wrote:
> > 
> 
> This patch seems to be in flux, ping me when it becomes ready.

This is ready now.

[alancutter (OOO until 2018), 2016-11-01 05:45:34]

Add TODO for offset-anchor: auto somewhere.

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-transform.html
(right):

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-transform.html:13:
offset: path('m 0 0 v 200') 100px auto;
There are quite a few things going on here, we should add a test that just
exercises offset-anchor and its interaction with transform-origin without other
factors clouding the expectation.

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1398:
floatValueForLength(transformOriginY(), boundingBox.height());
Needs a test for non-zero percentages.

[Eric Willigers, 2016-11-01 06:34:40]

> Add TODO for offset-anchor: auto somewhere.

Done

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-transform.html
(right):

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-transform.html:13:
offset: path('m 0 0 v 200') 100px auto;
On 2016/11/01 05:45:34, alancutter wrote:
> There are quite a few things going on here, we should add a test that just
> exercises offset-anchor and its interaction with transform-origin without
other
> factors clouding the expectation.

transform-origin is used for the independent transform properties. Then
offset-anchor is used for the motion path. Then transform-origin is used for the
transform property.

This test verifies that the correct origin is used at each stage.

I have split the test in two.

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2461603003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1398:
floatValueForLength(transformOriginY(), boundingBox.height());
On 2016/11/01 05:45:34, alancutter wrote:
> Needs a test for non-zero percentages.

Done. combine-independent-anchor-transform.html (combine-anchor-transform.html
and combine-independent-anchor.html) now uses percentages.

[Eric Willigers, 2016-11-01 06:34:46]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 06:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 07:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:53:23]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-11-03 00:46:52]

lgtm

https://codereview.chromium.org/2461603003/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-expected.html
(right):

https://codereview.chromium.org/2461603003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-expected.html:7:
span {
This should be display: inline-block.

https://codereview.chromium.org/2461603003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-expected.html:18:
<span>span3</div>
</span>

[Eric Willigers, 2016-11-03 04:01:06]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2016-11-03 04:01:36]

https://codereview.chromium.org/2461603003/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-expected.html
(right):

https://codereview.chromium.org/2461603003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-expected.html:7:
span {
On 2016/11/03 00:46:52, alancutter wrote:
> This should be display: inline-block.

Done.

https://codereview.chromium.org/2461603003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/combine-independent-anchor-expected.html:18:
<span>span3</div>
On 2016/11/03 00:46:52, alancutter wrote:
> </span>

Done.

[commit-bot: I haz the power, 2016-11-03 04:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 06:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 06:02:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Eric Willigers, 2016-11-03 06:08:14]

ericwilligers@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Eric Willigers, 2016-11-03 06:09:17]

+wangxianzhu@chromium.org for OWNERS

[Xianzhu, 2016-11-08 03:48:09]

Sorry for overlooking this. rs LGTM.

[Xianzhu, 2016-11-08 03:48:17]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-08 03:48:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2461603003/#ps180001
(title: "combine-anchor-transform.html")

[commit-bot: I haz the power, 2016-11-08 03:48:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 03:51:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2016-11-09 08:05:46]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-11-09 08:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2461603003/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-09 08:06:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 09:06:48]

Description was changed from

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

Spec: https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055
==========

to

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

Spec: https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055
==========

[commit-bot: I haz the power, 2016-11-09 09:06:49]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-11-09 09:09:16]

Description was changed from

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

Spec: https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055
==========

to

==========
CSS Motion Path: Place offset-anchor on the path

The offset-anchor, not transform-origin, is placed on the
path that is specified by offset-path.

"offset-anchor: auto" is not yet supported.

Spec: https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055

Committed: https://crrev.com/29e3535e5c89d73a975bcd0a97aaefe3c8653e80
Cr-Commit-Position: refs/heads/master@{#430896}
==========

[commit-bot: I haz the power, 2016-11-09 09:09:17]

Patchset 10 (id:??) landed as
https://crrev.com/29e3535e5c89d73a975bcd0a97aaefe3c8653e80
Cr-Commit-Position: refs/heads/master@{#430896}