Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2461553002: Always show (i) icon in Clank omnibox if HTTP_SHOW_WARNING is set (Closed)

Created:
4 years, 1 month ago by felt
Modified:
4 years, 1 month ago
Reviewers:
Maria
CC:
chromium-reviews, estark
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always show (i) icon in Clank omnibox if HTTP_SHOW_WARNING is set BUG=647564 Committed: https://crrev.com/7cc5461a9ad4988e8959113569a9c11a7b956f09 Cr-Commit-Position: refs/heads/master@{#428457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
felt
mariakhomenko, PTAL?
4 years, 1 month ago (2016-10-28 02:25:30 UTC) #7
Maria
lgtm
4 years, 1 month ago (2016-10-28 19:07:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461553002/1
4 years, 1 month ago (2016-10-28 19:09:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 19:17:05 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:24:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cc5461a9ad4988e8959113569a9c11a7b956f09
Cr-Commit-Position: refs/heads/master@{#428457}

Powered by Google App Engine
This is Rietveld 408576698