src/pdf/SkPDFShader.cpp - Issue 24615006: rebaseline drawbitmap gms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFShader.cpp

Issue 24615006: rebaseline drawbitmap gms (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: remove expectation included by mistake in another cl Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFShader.cpp

diff --git a/src/pdf/SkPDFShader.cpp b/src/pdf/SkPDFShader.cpp

index 80ea2f2ce717feeac26c0e41a0714aafdf671370..b7b76a766956722e9081e498523cfff909cc3935 100644

--- a/src/pdf/SkPDFShader.cpp

+++ b/src/pdf/SkPDFShader.cpp

@@ -9,7 +9,7 @@

#include "SkPDFShader.h"

-#include "SkCanvas.h"

+#include "SkCanvasSimplifier.h"

#include "SkData.h"

#include "SkPDFCatalog.h"

#include "SkPDFDevice.h"

@@ -870,8 +870,9 @@ SkPDFImageShader::SkPDFImageShader(SkPDFShader::State* state) : fState(state) {

unflip.preScale(SK_Scalar1, -SK_Scalar1);

SkISize size = SkISize::Make(SkScalarRound(deviceBounds.width()),

SkScalarRound(deviceBounds.height()));

+ // TODO(edisonn): should we pass here the DCT encoder of the destination device?

SkPDFDevice pattern(size, size, unflip);

- SkCanvas canvas(&pattern);

+ SkCanvasSimplifier canvas(&pattern);

SkRect patternBBox;

image->getBounds(&patternBBox);