rebaseline drawbitmap gms

rebaseline drawbitmap gms - somehow the git got confused and got and descrioption from another branch

[edisonn, 2013-09-26 16:01:46]

Ignore expectations file, I will revert it, as soon as iI figure out how to use
git properly

[reed1, 2013-09-26 17:00:46]

https://codereview.chromium.org/24615006/diff/3001/include/core/SkCanvasSimpl...
File include/core/SkCanvasSimplifier.h (right):

https://codereview.chromium.org/24615006/diff/3001/include/core/SkCanvasSimpl...
include/core/SkCanvasSimplifier.h:14: class SkCanvasSimplifier : public SkCanvas
{
1. Some dox for what this class does
2. Does it need to be public?

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h#...
include/core/SkDocument.h:58: const SkRect* mediaBox = NULL);
// What is stored in the doc if I pass null? Does it affect any of my drawing?

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h#...
include/core/SkDocument.h:73: bool close();
// What does returning true of false indicate?

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h#...
include/core/SkDocument.h:94: virtual bool setDCTEncoder(EncodeToDCTStream) {
1. Lets try very very hard to keep this header clear of any PDF specific headers
or types.
2. can we reuse the function-ptr definition in SkPicture.h (or come up with a
diff common one?)

SkData* (*EncodeBitmap)(size_t* pixelRefOffset, const SkBitmap& bm);

3. Is this something we need to allow to be set at different times during a
record? Can it be specified only in the factory, or only in beginPage?

[edisonn, 2013-09-26 19:44:09]

Code review moved at https://codereview.chromium.org/24811002/

https://codereview.chromium.org/24615006/diff/3001/include/core/SkCanvasSimpl...
File include/core/SkCanvasSimplifier.h (right):

https://codereview.chromium.org/24615006/diff/3001/include/core/SkCanvasSimpl...
include/core/SkCanvasSimplifier.h:14: class SkCanvasSimplifier : public SkCanvas
{
On 2013/09/26 17:00:46, reed1 wrote:
> 1. Some dox for what this class does
added a few lines of doc
> 2. Does it need to be public?
No, moved into src/doc

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h#...
include/core/SkDocument.h:58: const SkRect* mediaBox = NULL);
On 2013/09/26 17:00:46, reed1 wrote:
> // What is stored in the doc if I pass null? Does it affect any of my drawing?

added comment

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h#...
include/core/SkDocument.h:73: bool close();
On 2013/09/26 17:00:46, reed1 wrote:
> // What does returning true of false indicate?

added comment

https://codereview.chromium.org/24615006/diff/3001/include/core/SkDocument.h#...
include/core/SkDocument.h:94: virtual bool setDCTEncoder(EncodeToDCTStream) {
On 2013/09/26 17:00:46, reed1 wrote:
> 1. Lets try very very hard to keep this header clear of any PDF specific
headers
> or types.
> 2. can we reuse the function-ptr definition in SkPicture.h (or come up with a
> diff common one?)

Not yet implemented, working on it. For one, I also pass the rect of a part of
the image, I will talk with Leon about a common intertface

> 
> SkData* (*EncodeBitmap)(size_t* pixelRefOffset, const SkBitmap& bm);
> 
> 3. Is this something we need to allow to be set at different times during a
> record? Can it be specified only in the factory, or only in beginPage?

I think we should allow it only at the creation of the pdf. I Moved it in
CreatePdf

[edisonn, 2013-10-16 19:49:24]

Committed patchset #3 manually as r11829 (presubmit successful).