Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef MEDIA_VIDEO_CAPTURE_MAC_AVFOUNDATION_GLUE_H_ | |
| 6 #define MEDIA_VIDEO_CAPTURE_MAC_AVFOUNDATION_GLUE_H_ | |
| 7 | |
|
Mark Mentovai
2013/09/26 17:09:10
You need a comment saying why we have to do this i
mcasas
2013/09/30 17:53:50
Done.
| |
| 8 #import <Foundation/Foundation.h> | |
| 9 | |
| 10 @interface AVFoundationGlue : NSObject | |
| 11 | |
| 12 // This method returns YES if the OS version supports AVFoundation and the | |
| 13 // AVFoundation Bundle could be loaded correctly, or NO otherwise. | |
|
Mark Mentovai
2013/09/26 17:09:10
bundle uses a lowercase b.
mcasas
2013/09/30 17:53:50
Done.
| |
| 14 + (BOOL)IsAVFoundationSupported; | |
|
Mark Mentovai
2013/09/26 17:09:10
See previous comment about naming.
mcasas
2013/09/30 17:53:50
Done. Again, IsOsLionOrLater().
| |
| 15 | |
| 16 + (NSBundle*)getAVFoundationBundle; | |
|
Mark Mentovai
2013/09/26 17:09:10
Normal naming would just be avFoundationBundle.
mcasas
2013/09/30 17:53:50
Done.
| |
| 17 | |
| 18 @end // @interface AVFoundationGlue | |
| 19 | |
| 20 // Coming from AVCaptureDevice.h | |
| 21 @interface AVCaptureDeviceGlue : NSObject | |
| 22 | |
| 23 + (NSArray *)devices; | |
|
Mark Mentovai
2013/09/26 17:09:10
Above, you nestled the * up against the type name.
mcasas
2013/09/30 17:53:50
Done.
| |
| 24 | |
| 25 - (BOOL)hasMediaType:(NSString *)mediaType; | |
| 26 | |
| 27 @end | |
| 28 | |
| 29 extern NSString* const AVCaptureDeviceWasConnectedNotification = | |
| 30 @"AVCaptureDeviceWasConnectedNotification"; | |
|
Mark Mentovai
2013/09/26 17:09:10
You shouldn’t hard-code these 5 strings, you shoul
mcasas
2013/09/30 17:53:50
I couldn't do this because the strings are defined
| |
| 31 extern NSString* const AVCaptureDeviceWasDisconnectedNotification = | |
| 32 @"AVCaptureDeviceWasDisconnectedNotification"; | |
| 33 | |
| 34 // Coming from AVMediaFormat.h | |
| 35 extern NSString* const AVMediaTypeVideo = @"vide"; | |
| 36 extern NSString* const AVMediaTypeAudio = @"soun"; | |
| 37 extern NSString* const AVMediaTypeMuxed = @"muxx"; | |
| 38 | |
| 39 #endif // MEDIA_VIDEO_CAPTURE_MAC_AVFOUNDATION_GLUE_H_ | |
| OLD | NEW |