sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 24615003: Add DartType.treatAsRaw to treat List<dynamic> as List in the backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 24615003: Add DartType.treatAsRaw to treat List<dynamic> as List in the backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 333bd7e725947cb630a0096d80d4a4e9f3bac075..e19cdfa8a3793999dc02d28bd3f9a4cc4a57ad2f 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -651,7 +651,7 @@ class SsaInstructionSimplifier extends HBaseVisitor

HInstruction value = node.inputs[0];

DartType type = node.typeExpression;

if (type != null) {

- if (!type.isRaw || type.kind == TypeKind.TYPE_VARIABLE) {

+ if (!type.treatAsRaw || type.kind == TypeKind.TYPE_VARIABLE) {

return node;

}

if (type.kind == TypeKind.FUNCTION) {

@@ -769,7 +769,7 @@ class SsaInstructionSimplifier extends HBaseVisitor

HInstruction value = node.inputs.last;

if (compiler.enableTypeAssertions) {

DartType type = field.computeType(compiler);

- if (!type.isRaw || type.kind == TypeKind.TYPE_VARIABLE) {

+ if (!type.treatAsRaw || type.kind == TypeKind.TYPE_VARIABLE) {

// We cannot generate the correct type representation here, so don't

// inline this access.

return node;