Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 2461493002: Moves DragDropClient to aura/client (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asanka, sadrul, tfarina, jam, dcheng, darin-cc_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves DragDropClient to aura/client I'm going to need this in aura/client for mus. BUG=659155 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e Cr-Commit-Position: refs/heads/master@{#428121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -119 lines) Patch
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/drag_download_item_views.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/aura/client/drag_drop_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/aura/client/drag_drop_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_message_loop_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/drag_utils_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/drag_drop_client_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/drop_target_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/wm/core/compound_event_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
D ui/wm/public/drag_drop_client.h View 1 chunk +0 lines, -62 lines 0 comments Download
D ui/wm/public/drag_drop_client.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M ui/wm/public/scoped_drag_drop_disabler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years, 1 month ago (2016-10-27 17:58:16 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-10-27 18:24:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461493002/1
4 years, 1 month ago (2016-10-27 20:04:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 20:10:41 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 20:12:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e
Cr-Commit-Position: refs/heads/master@{#428121}

Powered by Google App Engine
This is Rietveld 408576698