Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2461463003: [stubs] Add FLAG_enable_slow_asserts check to CSA_SLOW_ASSERT (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add FLAG_enable_slow_asserts check to CSA_SLOW_ASSERT R=ishell@chromium.org BUG= Committed: https://crrev.com/fde9039fedd79890a593b898dc84817c81b994f5 Cr-Commit-Position: refs/heads/master@{#40666}

Patch Set 1 #

Patch Set 2 : doing the semicolon thing I was told to #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/code-stub-assembler.h View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Camillo Bruni
PTAL
4 years, 1 month ago (2016-10-28 12:26:38 UTC) #1
Igor Sheludko
lgtm
4 years, 1 month ago (2016-10-28 12:28:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461463003/1
4 years, 1 month ago (2016-10-28 12:37:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15407)
4 years, 1 month ago (2016-10-28 12:43:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461463003/20001
4 years, 1 month ago (2016-10-31 10:03:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 10:31:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fde9039fedd79890a593b898dc84817c81b994f5
Cr-Commit-Position: refs/heads/master@{#40666}

Powered by Google App Engine
This is Rietveld 408576698