Add a dummy entry with libsecret when initializing OSCrypt.

components/os_crypt/key_storage_libsecret.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/os_crypt/key_storage_libsecret.h"
 
 #include "base/base64.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "components/os_crypt/libsecret_util_linux.h"
@@ skipping 55 matching lines @@
   if (!success) {
     VLOG(1) << "Libsecret lookup failed.";
     return std::string();
   }
 
   VLOG(1) << "OSCrypt generated a new password.";
   return password;
 }
 
 std::string KeyStorageLibsecret::GetKey() {
+  LibsecretLoader::EnsureKeyringUnlocked();

[vasilii, 2016/10/28 09:36:24]

How often is this method called? Is it enough to unlock it once?

[cfroussios, 2016/10/28 11:21:22]

GetKey() is called once and its result will be cached.

We should only need to unlock the keyring once, and not expect that someone
would re-lock it. I've moved it to Init(). That doesn't have a practical effect,
but should remove the confusion.

+
   GError* error = nullptr;
   LibsecretAttributesBuilder attrs;
   attrs.Append("application", kApplicationName);
   GList* search_results = LibsecretLoader::secret_service_search_sync(
       nullptr /* default secret service */, &kKeystoreSchemaV2, attrs.Get(),
       static_cast<SecretSearchFlags>(SECRET_SEARCH_UNLOCK |
                                      SECRET_SEARCH_LOAD_SECRETS),
       nullptr, &error);
   if (error) {
     VLOG(1) << "Libsecret lookup failed: " << error->message;
@@ skipping 62 matching lines @@
   if (error) {
     VLOG(1) << "OSCrypt failed to delete deprecated password. "
             << error->message;
     g_error_free(error);
   }
 
   VLOG(1) << "OSCrypt migrated from deprecated password.";
 
   return password;
 }