Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2461383002: Revert of Add network throttling as an enterprise policy (Closed)

Created:
4 years, 1 month ago by tommycli
Modified:
4 years, 1 month ago
CC:
sduraisamy, Kevin Cernekee, Sameer Nanda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add network throttling as an enterprise policy (patchset #17 id:320001 of https://codereview.chromium.org/2364703002/ ) Reason for revert: Reverting because this broke CrOS ASan bots: First breaking build: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/17281 Thanks! Original issue's description: > Add support for an enterprise policy that lets the admin > turn on network throttling, and specify the upload and download rates in kbps to throttle to. > > BUG=642811 > TEST=(1) Unit-tests > (2) Added network throttling policy to YAPS server, > enabled throttling with various values, disabled, > and checked that changes propagate to client device. > > Signed-off-by: Kirtika Ruchandani <kirtika@google.com>; > Committed: https://crrev.com/7db3c2b899d448dc0235e03a248df83aa5778ebf > Cr-Commit-Position: refs/heads/master@{#428565} TBR=bartfab@chromium.org,stevenjb@chromium.org,kirtika@google.com,michaelpg@chromium.org,mnissler@chromium.org,atwilson@chromium.org,gab@chromium.org,brettw@chromium.org,isherman@chromium.org,asvitkine@chromium.org,thestig@chromium.org,kirtika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/chromeos/net/network_throttling_observer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_throttling_observer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tommycli
Created Revert of Add network throttling as an enterprise policy
4 years, 1 month ago (2016-10-31 15:20:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461383002/1
4 years, 1 month ago (2016-10-31 15:20:30 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 15:22:50 UTC) #5
Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698