Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2461313002: Revert 3 CLs depending each other to make the precise64 stable bot green. (Closed)

Created:
4 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 1 month ago
Reviewers:
asanka, lgarron, bustamante
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert 3 CLs depending each other to make the precise64 stable bot green. Several BrowsingDataRemoverTest test cases are failing on the bot. Revert "Use the Google report-uri for badssl Expect-CT site" This reverts commit a098fb135e247b02b70b8a9628922456be7f9750. Revert "HSTS preload list removals for Chrome 55." This reverts commit 93786d31433b6c3513da5680dfe121c9b1aa5ef2. Revert "[M54] Fix build." This reverts commit c0f81dce2f86e7dd4f87d68a1fc8501e29db2aad. R=asanka@chromium.org, bustamante@chromium.org, lgarron@chromium.org BUG=660297 Committed: https://chromium.googlesource.com/chromium/src/+/966721aac6d72b2f8bfdbe4a9d737b086c6b160c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M net/http/http_network_transaction_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/transport_security_state_static.json View 17 chunks +17 lines, -1 line 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (1 generated)
tyoshino (SeeGerritForStatus)
4 years, 1 month ago (2016-10-31 03:43:05 UTC) #1
bustamante
lgtm thanks!
4 years, 1 month ago (2016-10-31 03:46:58 UTC) #2
tyoshino (SeeGerritForStatus)
Committed patchset #1 (id:1) manually as 966721aac6d72b2f8bfdbe4a9d737b086c6b160c.
4 years, 1 month ago (2016-10-31 03:51:35 UTC) #4
lgarron
What are the BrowsingDataRemoverTest tests? And what branch is this meant to land on? I'd ...
4 years, 1 month ago (2016-10-31 03:54:21 UTC) #5
lgarron
Oh, er... seems I'm two minutes too late. :-/
4 years, 1 month ago (2016-10-31 03:54:44 UTC) #6
tyoshino (SeeGerritForStatus)
On 2016/10/31 03:54:21, lgarron wrote: > What are the BrowsingDataRemoverTest tests? > And what branch ...
4 years, 1 month ago (2016-10-31 04:19:57 UTC) #7
tyoshino (SeeGerritForStatus)
On 2016/10/31 04:19:57, tyoshino wrote: > On 2016/10/31 03:54:21, lgarron wrote: > > What are ...
4 years, 1 month ago (2016-10-31 04:25:50 UTC) #8
asanka
On 2016/10/31 at 04:25:50, tyoshino wrote: > On 2016/10/31 04:19:57, tyoshino wrote: > > On ...
4 years, 1 month ago (2016-10-31 14:07:42 UTC) #9
asanka
On 2016/10/31 at 14:07:42, asanka wrote: > On 2016/10/31 at 04:25:50, tyoshino wrote: > > ...
4 years, 1 month ago (2016-10-31 14:09:18 UTC) #10
tyoshino (SeeGerritForStatus)
4 years, 1 month ago (2016-11-02 07:57:25 UTC) #11
Message was sent while issue was closed.
On 2016/10/31 14:09:18, asanka wrote:
> On 2016/10/31 at 14:07:42, asanka wrote:
> > On 2016/10/31 at 04:25:50, tyoshino wrote:
> > > On 2016/10/31 04:19:57, tyoshino wrote:
> > > > On 2016/10/31 03:54:21, lgarron wrote:
> > > > > What are the BrowsingDataRemoverTest tests?
> > > > > And what branch is this meant to land on?
> > > > 
> > > > Please see http://go/stablebuilders to see the tests broken. The build
> logs are
> > > > also linked from http://crbug.com/660297.
> > > > 
> > > > The branch is 2840, i.e. M54 stable. Please see the "target ref" on the
> code
> > > > review tool.
> > > > 
> > > > > I'd prefer to avoid landing this if there's a direct path to fix,
since
> this
> > > > is
> > > > > going to force me to chase down stuff to make sure security is up to
> date on
> > > > the
> > > > > right branches. and mess up the history for
> > > > transport_security_state_static.json
> > > > > unnecessarily (which will require hacky workarounds for future work).
> > > > 
> > > > It doesn't affect the trunk. You can just reland the three patches to
2840
> once
> > > > it's fixed. It's only about the branch.
> > > 
> > > Ah, but yes, it would bother you by requiring you to merge the fix you
write
> for the trunk to this branch.
> > > 
> > > If http://crbug.com/655854 is a stable release blocker (which a point I
> didn't check), this revert doesn't help anything as it's not preventing other
> merges from being tested on go/stablebuilders. If so, sorry about that.
> > 
> > not lgtm.
> > 
> > c0f81dce2f86e7dd4f87d68a1fc8501e29db2aad isn't interdependent with any of
the
> other CLs here and I don't think the tree will build without it.
> 
> Ah I see that c0f81dce2f86e7dd4f87d68a1fc8501e29db2aad was reverted by
mistake.
> https://bugs.chromium.org/p/chromium/issues/detail?id=660297#c21

Right, my bad!

Powered by Google App Engine
This is Rietveld 408576698