Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2461273002: Revert of Disable flaky testWebAppSplashscreenIsDownloaded test. (Closed)

Created:
4 years, 1 month ago by dominickn
Modified:
4 years, 1 month ago
Reviewers:
phoglund_chromium, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky testWebAppSplashscreenIsDownloaded test. (patchset #1 id:1 of https://codereview.chromium.org/2458963002/ ) Reason for revert: The offending CL that caused the failures has been reverted (crrev.com/2362033002) Original issue's description: > Disable flaky testWebAppSplashscreenIsDownloaded test. > > I commented out @SmallTest etc since almost all instances of > DisabledTest in code search also commented SmallTest out. That doesn't > make any sense to me though; surely commenting out cannot be necessary > unless DisabledTest has no effect at all on the test runner? > > BUG=660237 > TBR=dfalcantara@chromium.org > > Committed: https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57 > Cr-Commit-Position: refs/heads/master@{#428331} TBR=dfalcantara@chromium.org,phoglund@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660237 Committed: https://crrev.com/774704ae97973e1f9cde57e2a9c7818a8d3b5196 Cr-Commit-Position: refs/heads/master@{#428635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dominickn
Created Revert of Disable flaky testWebAppSplashscreenIsDownloaded test.
4 years, 1 month ago (2016-10-30 22:53:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461273002/1
4 years, 1 month ago (2016-10-30 22:53:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-30 23:21:29 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-30 23:24:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/774704ae97973e1f9cde57e2a9c7818a8d3b5196
Cr-Commit-Position: refs/heads/master@{#428635}

Powered by Google App Engine
This is Rietveld 408576698