Issue 246123005: SPDY cleanups: remove extraneous 'net::' & obsolete TODO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246123005: SPDY cleanups: remove extraneous 'net::' & obsolete TODO (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove net:: when referencing types from code locations already within the net:: namespace. This lands server change 64909661 by hkhalil. Remove obsolete TODO. This lands server change 64909678 by hkhalil. BUG=

Patch Set 1 #

Patch Set 2 : Also include cr/64909678 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -36 lines)			Patch
M	net/spdy/spdy_framer.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View		22 chunks	+26 lines, -26 lines	0 comments	Download
M	net/spdy/spdy_protocol_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

thanks for the cleanup

Expand Messages | Collapse Messages