Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: components/signin/core/browser/about_signin_internals.h

Issue 2461223003: Remove stl_util's deletion function use from components/signin/. (Closed)
Patch Set: more loop Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/signin/core/browser/about_signin_internals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/about_signin_internals.h
diff --git a/components/signin/core/browser/about_signin_internals.h b/components/signin/core/browser/about_signin_internals.h
index 7af382bfc8e4b8cfc574c758fb3ed46611751faf..0e32b0eb345f91331ce9087e61612a6172a903c0 100644
--- a/components/signin/core/browser/about_signin_internals.h
+++ b/components/signin/core/browser/about_signin_internals.h
@@ -32,7 +32,7 @@ class SigninClient;
// Many values in SigninStatus are also associated with a timestamp.
// This makes it easier to keep values and their associated times together.
-typedef std::pair<std::string, std::string> TimedSigninStatusValue;
+using TimedSigninStatusValue = std::pair<std::string, std::string>;
// This class collects authentication, signin and token information
// to propagate to about:signin-internals via SigninInternalsUI.
@@ -110,7 +110,8 @@ class AboutSigninInternals
~TokenInfo();
std::unique_ptr<base::DictionaryValue> ToValue() const;
- static bool LessThan(const TokenInfo* a, const TokenInfo* b);
+ static bool LessThan(const std::unique_ptr<TokenInfo>& a,
+ const std::unique_ptr<TokenInfo>& b);
// Called when the token is invalidated.
void Invalidate();
@@ -124,15 +125,15 @@ class AboutSigninInternals
bool removed_;
};
- // Map account id to tokens associated to the account.
- typedef std::map<std::string, std::vector<TokenInfo*> > TokenInfoMap;
-
// Encapsulates both authentication and token related information. Used
// by SigninInternals to maintain information that needs to be shown in
// the about:signin-internals page.
struct SigninStatus {
std::vector<TimedSigninStatusValue> timed_signin_fields;
- TokenInfoMap token_info_map;
+
+ // Map account id to tokens associated to the account.
+ std::map<std::string, std::vector<std::unique_ptr<TokenInfo>>>
+ token_info_map;
SigninStatus();
~SigninStatus();
« no previous file with comments | « no previous file | components/signin/core/browser/about_signin_internals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698