Remove stl_util's deletion function use from components/signin/.

Remove stl_util's deletion function use from components/signin/.

BUG=555865
Committed: https://crrev.com/8bbf78833905b9b0ddf4edf17ae5902ef720aa99
Cr-Commit-Position: refs/heads/master@{#430689}

[Avi (use Gerrit), 2016-10-30 22:43:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 22:44:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-30 23:26:10]

avi@chromium.org changed reviewers:
+ atwilson@chromium.org

[commit-bot: I haz the power, 2016-10-30 23:40:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 23:40:07]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-04 14:57:18]

avi@chromium.org changed reviewers:
+ rogerta@chromium.org

[Avi (use Gerrit), 2016-11-04 14:57:19]

PTAL, thanks!

[Roger Tawa OOO till Jul 10th, 2016-11-08 15:40:34]

Hi Avi, a couple of questions below.  Thanks.

https://codereview.chromium.org/2461223003/diff/1/components/signin/core/brow...
File components/signin/core/browser/about_signin_internals.cc (right):

https://codereview.chromium.org/2461223003/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:340: for (const auto&
token : signin_status_.token_info_map[account_id]) {
For my own info, is there a danger of doing:

  for (const auto token : signin_status_.token_info_map[account_id])

or:

  for (auto token : signin_status_.token_info_map[account_id])

and having the map modified during iteration?

Is this possibly a case where auto hides too much info?  Maybe these loops
should be written:

  for (const std::unique_ptr<TokenInfo>& token :
           signin_status_.token_info_map[account_id]) {
  }

https://codereview.chromium.org/2461223003/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:421:
std::tie(b->request_time, b->consumer_id, b->scopes);
That's neat :-)

[Avi (use Gerrit), 2016-11-08 17:25:22]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 17:25:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 18:33:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 18:33:10]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-08 18:50:51]

https://codereview.chromium.org/2461223003/diff/1/components/signin/core/brow...
File components/signin/core/browser/about_signin_internals.cc (right):

https://codereview.chromium.org/2461223003/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:340: for (const auto&
token : signin_status_.token_info_map[account_id]) {
On 2016/11/08 15:40:34, Roger Tawa wrote:
>   for (const auto token : signin_status_.token_info_map[account_id])
>   for (auto token : signin_status_.token_info_map[account_id])

You can't do either of those. auto would deduce the type as unique_ptr<> which
is non-copyable, so it would fail to compile as it tried to make a copy of each
of the unique_ptrs.

>   for (const std::unique_ptr<TokenInfo>& token :
>            signin_status_.token_info_map[account_id]) {
>   }

That would be clearer. I'll do that.

https://codereview.chromium.org/2461223003/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:421:
std::tie(b->request_time, b->consumer_id, b->scopes);
On 2016/11/08 15:40:34, Roger Tawa wrote:
> That's neat :-)

Indeed it is :)

[Roger Tawa OOO till Jul 10th, 2016-11-08 18:53:03]

lgtm

Thanks for the info.

[Roger Tawa OOO till Jul 10th, 2016-11-08 18:54:29]

Note that my comment about loops and not using auto could apply to other loops

[Avi (use Gerrit), 2016-11-08 18:56:56]

On 2016/11/08 18:54:29, Roger Tawa wrote:
> Note that my comment about loops and not using auto could apply to other loops

Changing those too.

[Avi (use Gerrit), 2016-11-08 18:59:05]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-11-08 18:59:06]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/2461223003/#ps40001
(title: "more loop")

[commit-bot: I haz the power, 2016-11-08 18:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 19:52:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 20:10:44]

Description was changed from

==========
Remove stl_util's deletion function use from components/signin/.

BUG=555865
==========

to

==========
Remove stl_util's deletion function use from components/signin/.

BUG=555865

Committed: https://crrev.com/8bbf78833905b9b0ddf4edf17ae5902ef720aa99
Cr-Commit-Position: refs/heads/master@{#430689}
==========

[commit-bot: I haz the power, 2016-11-08 20:10:46]

Patchset 3 (id:??) landed as
https://crrev.com/8bbf78833905b9b0ddf4edf17ae5902ef720aa99
Cr-Commit-Position: refs/heads/master@{#430689}