Issue 2461173002: Disable memory cache for ArrayBuffer XHRs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2461173002: Disable memory cache for ArrayBuffer XHRs (Closed)

Created:
4 years, 1 month ago by halliwell

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable memory cache for ArrayBuffer XHRs XHRs get removed from memory cache anyway after load finishes (see issue 399166). This change can save significant memory during the fetch for large resources. BUG=659789

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

halliwell

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-29 13:42:51 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461173002/1

4 years, 1 month ago (2016-10-29 13:42:55 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-29 15:09:12 UTC) #3

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 1 month ago (2016-10-29 15:09:13 UTC) #4

halliwell

4 years ago (2016-12-14 15:40:55 UTC) #5

Description was changed from

==========
Disable memory cache for ArrayBuffer XHRs

XHRs get removed from memory cache anyway after load finishes (see
issue 399166).  This change can save significant memory during the
fetch for large resources.

BUG=659789
==========

to

==========
Disable memory cache for ArrayBuffer XHRs

XHRs get removed from memory cache anyway after load finishes (see
issue 399166).  This change can save significant memory during the
fetch for large resources.

BUG=659789
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages