Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/web/tests/ViewportTest.cpp

Issue 2461143002: Reconstrain zoom value to the [min-zoom, max-zoom] range before it used (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2896 matching lines...) Expand 10 before | Expand all | Expand 10 after
2907 2907
2908 TEST_F(ViewportTest, viewportLimitsAdjustedForNoUserScale) { 2908 TEST_F(ViewportTest, viewportLimitsAdjustedForNoUserScale) {
2909 registerMockedHttpURLLoad( 2909 registerMockedHttpURLLoad(
2910 "viewport/viewport-limits-adjusted-for-no-user-scale.html"); 2910 "viewport/viewport-limits-adjusted-for-no-user-scale.html");
2911 2911
2912 FrameTestHelpers::WebViewHelper webViewHelper; 2912 FrameTestHelpers::WebViewHelper webViewHelper;
2913 webViewHelper.initializeAndLoad( 2913 webViewHelper.initializeAndLoad(
2914 m_baseURL + "viewport/viewport-limits-adjusted-for-no-user-scale.html", 2914 m_baseURL + "viewport/viewport-limits-adjusted-for-no-user-scale.html",
2915 true, nullptr, nullptr, nullptr, setViewportSettings); 2915 true, nullptr, nullptr, nullptr, setViewportSettings);
2916 2916
2917 webViewHelper.webView()->updateAllLifecyclePhases();
2917 Page* page = webViewHelper.webView()->page(); 2918 Page* page = webViewHelper.webView()->page();
2919 PageScaleConstraints constraints = runViewportTest(page, 10, 10);
2918 2920
2919 EXPECT_FALSE(page->viewportDescription().userZoom); 2921 EXPECT_FALSE(page->viewportDescription().userZoom);
2922 EXPECT_NEAR(1.0f, constraints.initialScale, 0.01f);
2923 EXPECT_NEAR(1.0f, constraints.minimumScale, 0.01f);
2920 } 2924 }
2921 2925
2922 TEST_F(ViewportTest, viewportLimitsAdjustedForNoUserScaleControl) { 2926 TEST_F(ViewportTest, viewportLimitsAdjustedForUserScale) {
bokan 2016/10/31 13:58:19 Good catch!
2923 registerMockedHttpURLLoad( 2927 registerMockedHttpURLLoad(
2924 "viewport/viewport-limits-adjusted-for-no-user-scale-control.html"); 2928 "viewport/viewport-limits-adjusted-for-user-scale.html");
2925 2929
2926 FrameTestHelpers::WebViewHelper webViewHelper; 2930 FrameTestHelpers::WebViewHelper webViewHelper;
2927 webViewHelper.initializeAndLoad( 2931 webViewHelper.initializeAndLoad(
2928 m_baseURL + 2932 m_baseURL + "viewport/viewport-limits-adjusted-for-user-scale.html", true,
2929 "viewport/viewport-limits-adjusted-for-no-user-scale-control.html", 2933 nullptr, nullptr, nullptr, setViewportSettings);
2930 true, nullptr, nullptr, nullptr, setViewportSettings);
2931 2934
2935 webViewHelper.webView()->updateAllLifecyclePhases();
2932 Page* page = webViewHelper.webView()->page(); 2936 Page* page = webViewHelper.webView()->page();
2937 PageScaleConstraints constraints = runViewportTest(page, 10, 10);
2933 2938
2934 EXPECT_TRUE(page->viewportDescription().userZoom); 2939 EXPECT_TRUE(page->viewportDescription().userZoom);
2940 EXPECT_NEAR(1.0f, constraints.initialScale, 0.01f);
2941 EXPECT_NEAR(1.0f, constraints.minimumScale, 0.01f);
2935 } 2942 }
2936 2943
2937 TEST_F(ViewportTest, viewportTriggersGpuRasterization) { 2944 TEST_F(ViewportTest, viewportTriggersGpuRasterization) {
2938 FrameTestHelpers::WebViewHelper webViewHelper; 2945 FrameTestHelpers::WebViewHelper webViewHelper;
2939 2946
2940 registerMockedHttpURLLoad( 2947 registerMockedHttpURLLoad(
2941 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html"); 2948 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html");
2942 webViewHelper.initializeAndLoad( 2949 webViewHelper.initializeAndLoad(
2943 m_baseURL + 2950 m_baseURL +
2944 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html", 2951 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html",
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
3199 m_baseURL + "viewport/viewport-warnings-7.html", true, &webFrameClient, 3206 m_baseURL + "viewport/viewport-warnings-7.html", true, &webFrameClient,
3200 nullptr, nullptr, setViewportSettings); 3207 nullptr, nullptr, setViewportSettings);
3201 3208
3202 Page* page = webViewHelper.webView()->page(); 3209 Page* page = webViewHelper.webView()->page();
3203 runViewportTest(page, 320, 352); 3210 runViewportTest(page, 320, 352);
3204 3211
3205 EXPECT_EQ(0U, webFrameClient.messages.size()); 3212 EXPECT_EQ(0U, webFrameClient.messages.size());
3206 } 3213 }
3207 3214
3208 } // namespace blink 3215 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698