Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2461133002: Prevent overflow by falling back to non-AA (Closed)

Created:
4 years, 1 month ago by liyuqian
Modified:
4 years, 1 month ago
Reviewers:
f(malita), caryclark, reed1
CC:
reviews_skia.org, f(malita), rnephew (Reviews Here)
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Prevent overflow by falling back to non-AA This piece of code is directly copied from our old supersampling AA code. I didn not preserve this code because it's not triggered by any Skia tests. However, this will be critical to Chromium's tests as some websites will generate huge paths! I'm not so sure whether the long_running_idle_gmail_background_tbmv2 test failed because of this. But I'm sure that www.nationalgeographic.com from page_cycler_v2.typical_25 failed because of this. BUG=chromium:660394 TBR=reed@google.com,caryclark@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461133002 Committed: https://skia.googlesource.com/skia/+/a3316adf63ca168c9125df965cfa85bdd7b50a1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/core/SkScan_AAAPath.cpp View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461133002/1
4 years, 1 month ago (2016-10-28 23:37:20 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 1 month ago (2016-10-28 23:37:21 UTC) #5
liyuqian
Hi Florin, I'm not sure whether the TBR would work so I added you as ...
4 years, 1 month ago (2016-10-28 23:40:26 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 00:16:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a3316adf63ca168c9125df965cfa85bdd7b50a1c

Powered by Google App Engine
This is Rietveld 408576698