ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js - Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu.

Unified Diff: ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu. (Closed)

Patch Set: Add missing dep Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

diff --git a/chrome/browser/resources/settings/settings_action_menu.js b/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

similarity index 97%

rename from chrome/browser/resources/settings/settings_action_menu.js

rename to ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

index 808a7bf792bd175fbbdca594110fa4f025380d3f..ad7b9a031c063983eb2c8edd8852e052fdb025ec 100644

--- a/chrome/browser/resources/settings/settings_action_menu.js

+++ b/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

@@ -3,7 +3,7 @@

// found in the LICENSE file.

Polymer({

- is: 'settings-action-menu',

+ is: 'cr-action-menu',

extends: 'dialog',

/**

@@ -122,7 +122,7 @@ Polymer({

this.showModal();

var rect = anchorElement.getBoundingClientRect();

- if (new settings.DirectionDelegateImpl().isRtl()) {

+ if (isRTL()) {

Dan Beam 2016/11/02 16:36:12 can we just call getComputedStyle(anchorElement).d

dpapad 2016/11/02 17:24:13 I am reluctant calling getComputedStyle() every ti

Dan Beam 2016/11/02 18:54:18 i think in generic components (that don't necessar

var right = window.innerWidth - rect.left - this.offsetWidth;

this.style.right = right + 'px';

} else {