chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js - Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu. (Closed)

Patch Set: getComputedStyle instead of util.js Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | chrome/browser/resources/settings/printing_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

index d88119de4a78227648b9fc9225c590355639e25b..66e5a042713228801b50dfec9153e8851fcd1250 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

@@ -90,7 +90,7 @@ Polymer({

* @private

onMenuEditPasswordTap_: function() {

- /** @type {SettingsActionMenuElement} */(this.$.menu).close();

+ /** @type {CrActionMenuElement} */(this.$.menu).close();

this.showPasswordEditDialog_ = true;

@@ -132,7 +132,7 @@ Polymer({

onMenuRemovePasswordTap_: function() {

this.fire('remove-saved-password', this.activePassword.loginPair);

- /** @type {SettingsActionMenuElement} */(this.$.menu).close();

+ /** @type {CrActionMenuElement} */(this.$.menu).close();

/**

@@ -157,7 +157,7 @@ Polymer({

* @private

onPasswordMenuTap_: function(e) {

- var menu = /** @type {!SettingsActionMenuElement} */(this.$.menu);

+ var menu = /** @type {!CrActionMenuElement} */(this.$.menu);

var target = /** @type {!Element} */(Polymer.dom(e).localTarget);

var passwordUiEntryEvent = /** @type {!PasswordUiEntryEvent} */(e);