chrome/browser/resources/settings/on_startup_page/startup_url_entry.js - Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu. (Closed)

Patch Set: getComputedStyle instead of util.js Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/startup_url_entry.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

index e0fff60b06c1111a5b7567aeb788bf994cc342dc..e3e93dda2bb254b9479b25b0f104870554ddb27a 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

+++ b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

@@ -36,20 +36,20 @@ Polymer({

/** @private */

onRemoveTap_: function() {

- this.$$('dialog[is=settings-action-menu]').close();

+ this.$$('dialog[is=cr-action-menu]').close();

settings.StartupUrlsPageBrowserProxyImpl.getInstance().removeStartupPage(

this.model.modelIndex);

/** @private */

onEditTap_: function() {

- this.$$('dialog[is=settings-action-menu]').close();

+ this.$$('dialog[is=cr-action-menu]').close();

this.fire(settings.EDIT_STARTUP_URL_EVENT, this.model);

/** @private */

onDotsTap_: function() {

- var actionMenu = /** @type {!SettingsActionMenuElement} */(

+ var actionMenu = /** @type {!CrActionMenuElement} */(

this.$.menu.get());

actionMenu.showAt(assert(this.$.dots));